Bug 6747 - Jive should not be shown as a 'player'
: Jive should not be shown as a 'player'
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Web UI
: unspecified
: Macintosh Other
: P2 major (vote)
: 7.0
Assigned To: Michael Herger
http://www.squeezenetwork.com/player/...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-23 12:06 UTC by Andy Grundman
Modified: 2009-09-08 09:16 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-01-23 12:06:41 UTC
Maybe we need to add a listing of 'controllers' in addition to 'players'...
Comment 1 Brandon Black 2008-01-28 10:25:42 UTC
This removes controllers from the playerlist dropbox for the controls on the top right of home, by removing it from netcontrol.  Not sure if this is ultimately what you want to do or not (as opposed to ignoring it in the js for the player thing itself, and using the netcontrol data for the controller elsewhere on the page):

=== docroot/netcontrol/netcontrolxml.tt
==================================================================
--- docroot/netcontrol/netcontrolxml.tt	(revision 22983)
+++ docroot/netcontrol/netcontrolxml.tt	(local)
@@ -11,6 +11,7 @@
 
 		<players>
 			[% FOREACH player = players %]
+			[% NEXT IF player.type.match('Controller') %]
 				<player id="[% player.id %]" serviceip="[% player.serviceip %]" bestname="[%- player.bestName | encode_entities -%]" />
 			[% END %]
 		</players>
Comment 2 Matthew J. Martin 2008-01-29 18:20:24 UTC
added method in service/SDI/Service/Model/Player.pm to get list of user's players filtered by array of desired types with convenience method to get players or controllers only. As a general rule (whenever possible) the Controller should filter data being passed to the View - Views should not contain logic about types of players, for example, because this will change and need to be updated across multiple templates.
Comment 3 Anoop Mehta 2008-02-28 12:58:07 UTC
Connected to SN today, Updated firmware to 2063 and when I added my Ray to my SN account, it also added my Jive to my SN account under players. 

Jive MAC address : 00:04:20:1A:03:E1
SN account: Anoop@slimdevices.com

SN account under players shows: Squeezebox Controller and Squeezebox reciever. 
Comment 4 Anoop Mehta 2008-02-28 13:17:20 UTC
After speaking with Matthew M......Instead of having a Players option, It should be a Devices option? 

Up in the top right hand corner, instead of players it should read Devivces. 

Above the list of players it should also say Devices. 
Comment 5 Andy Grundman 2008-02-28 13:24:22 UTC
Talk to Dean first.
Comment 6 Matthew J. Martin 2008-02-28 14:27:24 UTC
Nomenclature needs to be consistent on this page: 

(from "About My Devices" box)

"Use this screen to add a new Squeezebox, Transporter or Controller to your account or adjust the settings on your device. You can also delete a device from your account if you are no longer using it.

To add a device, choose SqueezeNetwork during setup, from the Home menu or in Settings under Music Sources.

If your device hasn’t been connected to SqueezeNetwork before, your Player Idendification Number or PIN, will be displayed. If your device has been connected before, look for the PIN in Settings.

Enter the PIN in the box to the right and choose a name for your player, such as Living Room, then click Add."



- About copy last sentence reads "name for your player" should be changed to "name for your device".

- Title of devices list is "Players" should read "Devices" since it indeed displays a list of both players and controllers. 

- "Add A Device" box has labels "Player Name" and "Add Player". Instead, these should read "Device Name" and "Add Device" since "About My Devices" box indicates you should "Use this screen to add a new Squeezebox, Transporter or Controller" 



Comment 7 Blackketter Dean 2008-02-28 14:34:08 UTC
I'm going to make a command decision here and use the word "Player".  I was wrong when I had it changed to Devices

Please change "Device" to "Player" everywhere on this page.

The only confusion/inconsistency here is that there will be SBCs in the Player List.  This is acceptable, especially considering that they will be players soon. 


Comment 8 Blackketter Dean 2008-02-28 14:34:22 UTC
And I promise to stop smoking crack.

Comment 9 Michael Herger 2008-02-29 04:33:47 UTC
change 2786 
Comment 10 James Richardson 2008-05-15 13:01:58 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html