Bugzilla – Bug 6734
Make auto-forgetting stream.mp3 clients configurable
Last modified: 2009-07-31 10:16:24 UTC
Auto-forgetting stream.mp3 clients was added in rev 15220. This represents a change in functionality from 6.5.x, most notably because when a stream.mp3 client reconnects, it begins playing the currently-playing track from the beginning. In 6.5.x, the client will pick up where it dropped off. This is most significant for very long tracks, especially 60 minute single-track mixes. It's fine to auto-forget them, but I'd very much appreciate an option to use the old behavior. Currently, I'm editing Slim/Web/HTTP.pm to remove the block of code every time I update. Auto-forgetting clients is also causing an odd bug that I haven't yet tried to reproduce: When I stop and start my connection to the stream, reload the web interface, and view the playlist for the stream.mp3 client, most of the time it shows an empty playlist. However, the client is listening to the last-played track from the previous playlist (as expected). Since it doesn't show me the playlist, though, I can't change or stop what the client is listening to, and if I add new items to the playlist, they are ignored. About 1/5 times, if I reload the page, the real playlist appears and I can resolve it. Also, when this is happening, if I stop and start my connection to the client several times, the flac decoder+lame encoder processes hang around, eating up CPU until I kill them or restart squeezecenter. That said, I haven't tried to reproduce those on another install. If I do, I'll create a new bug for that issue.
Seems like a reasonable request, post 7.0.
(In reply to comment #0) I'm struggling with the same issue, but I consider the issue critical since the only way to play more than one song is to switch (skip) manually. My mp3 player reaches EOF at the end of each song, disconnects, and when I open the stream.mp3 again, the song repeats.
I've found that SC automatically forgets clients that play from stream.mp3. This has actually led to some undesirable behavior for my SC system. I've got an MP3 client running on my SC server box that automatically checks every 10 seconds to see if there's a stream to play on 127.0.0.1. Such streams should theoretically appear only when a user has instructed SC to play from a playlist. Streams should not exist if the playlist has been stopped or the playlist has reached its end and repeat has been turned off. I'm finding a problem with that latter case; since SC now forgets client MP3 players, whenever my client reaches the end of a playlist and then disconnects, I think SC forgets the player and forgets that the player ever reached the playlist ended. Thus, when my client automatically checks again in 10 seconds to see if there's a stream to play, SC obliges and starts the playlist over. Playlists will not stop repeating if MP3 clients have their queries in a loop, even if repeat is turned off on the playlists.
Michael: I reverted the change that auto-forgets stream.mp3 clients when they disconnect. Change 20692. The JS code that was used to implement the 'Forget this player' link no longer works with 7.1. Can you take a look at porting it? Diff here: http://svn.slimdevices.com/viewvc.cgi/trunk/server/HTML/EN/settings/player/basic.html?r1=17183&r2=17182&pathrev=17183
Also note, the forget link should be wrapped in a block: [% IF !macaddress %] so it only appears for stream.mp3 players and not hardware players.
change 20723 - add "forget" link back to the basic player settings page
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC