Bugzilla – Bug 6725
Incorrect sort order for Internet Radio
Last modified: 2009-09-08 09:32:13 UTC
Jive's menu order under internet radio is not in line with the spec. It needs to be: * Staff Picks * radioio.com * RadioTime * Live365 * SHOUTcast This is correct in player ui and web ui. Jive is currently: Sound and Effects SHOUTcast RadioTime radioio.com Staff Picks Live365
Bug 6535 covers the issue of sound & effects being incorrectly located in internet radio
Created attachment 2711 [details] one possible method this works, pushing the third-party and two items-to-be-moved to the end of the list (any undefined weight gets set to 100). The only thing I haven't sorted out is how to deal with the cmp change to <=> in sortResultLoop. This is required for numeric, but we may still need cmp for string fields. I'm not sure what method we've used to deal with this before and I don't think we want to use alpha weights when numeric is already in use elsewhere.
A weight value sounds like the right solution. It would be best if we could make it use the rank-* prefs, but I guess those are backwards from the way Jive orders.
consistency, I guess :) rank prefs do make sense, as eventually the demand will rise for reordering by user preference. This will need to be something common to jive/SC and each menu section. The patch does need more work, and I'll keep plodding.
The starting order for these items should follow what's in http://wiki.slimdevices.com/index.cgi?UserInterfaceHierarchy Can we fix that first?
that's exactly what this patch does (initial comment followed from the wiki), with the exception of not yet handling the two items not belonging in the menu at all (covered by bug 6535)
Created attachment 2716 [details] patch with wiki order ok, this solves the order to match the wiki for the valid radio items AND the music services. For now at least, this uses the same "weight" method as the browse menu ordering. This patch will tack any third party items to the end of the list (because they currently have no defined weight). Sounds and Podcasts are REMOVED from the menu by this patch, but are prepped for adding to the extras menu. This, however, needs more work as Extras is currently a jive menu, rather than query-built.
comitted to 7.0 at change 16724. please reopen if there are issues.
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html