Bug 6719 - don't localize whatever is in the 'TYPE' tag on songinfo queries
: don't localize whatever is in the 'TYPE' tag on songinfo queries
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P2 minor (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-22 10:44 UTC by Ben Klaas
Modified: 2009-09-08 09:32 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2008-01-22 10:44:23 UTC
'TYPE' tag (populated from database, track.content_type) returns a lot of different things:

MP3
MP3 (Live 365)
FLAC
INTERNET RADIO

this should be sent to Jive without localization. Right now it's throwing errors on the SC console whenever there's no localization available.

Dean, I have a fix for this, already tested. Just need your approval to checkin for 7.0.
Comment 1 Blackketter Dean 2008-01-22 11:52:53 UTC
Where are all those weird strings coming from?  Cleaning up the console is good, but should the data be fixed?
Comment 2 Ben Klaas 2008-01-22 11:59:32 UTC
Figured that was coming :)

I'm only concerned about Jive and what gets displayed on the songinfo window here. I'm not about to touch something that isn't right in the database. The TYPE tag in the query results is populated from what looks to be tracks.content_type.

I've checked in the fix as change 16606 on 7.0. 

If there's a SC bug to fix on that database field, it should be opened as a different bug.
Comment 3 KDF 2008-01-22 12:08:05 UTC
content type has previously been used as a token so that pages like the file types settings can be localised, as well as the song info/track info views in player and web ui.  It seems that recently some content types have taken on variants that are expecting to be treated as raw strings, instead of tokens (content_type = MP3 (Live 365) for example).  

So, in legacy terms, the type was intended to be localised. This is how MOV becomes "Apple AAC for Movie File"
Comment 4 James Richardson 2008-05-15 13:01:50 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html