Bugzilla – Bug 6706
don't display 'play this song' and 'add this song' links when track is a remote stream
Last modified: 2008-05-15 13:01:48 UTC
I have a fix for this, just need a bug number
fixed in SC change 16550 Dean, sorry I should have checked with you first on this before targetting at 7.0 seemed like an obvious fix needed when I saw 'play this song' for a radio stream, which looked all wrong. Assigning to you for opinion. If you don't want it in 7.0, push it back to me and I'll back out the fix. Otherwise, move it to RESOLVED
It's not unreasonable to have "Play Song" and "Add Song" for remote items, especially if they are Rhapsody, MP3Tunes or LMA tracks. And even for radio stations, it's ok to have "Play" and even "Add", without "song".
so... if ($track->remote) { play string is PLAY add string is ADD_SONG } else { play string is PLAY_SONG add string is ADD_SONG } otherwise leave these items in for ALL tracks, no matter what. Correct?
whoops, that should have read if ($track->remote) { play string is PLAY add string is ADD } else { play string is PLAY_SONG add string is ADD_SONG }
That would be fine, but just to be clear... "Song" implies that it has a fixed length, which is true for all local items and many remote ones. Only the ones without fixed lengths should not have "song" and probably have "station" instead. If this is hard/risky, then the pseudo code is ok, and we can clean it up later.
the pseudo code will cover it for now. FYI, the songinfo queries for Rhapsody, Pandora, etc. are not the same as the SC songinfo query, and thus are not affected by this. Play Song for local tracks Play for remote tracks (e.g., radio streams) Rhapsody/Pandora serve up different items to this screen
sorry, change 16557 has the fix
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html