Bug 6691 - Asian UTF-8 displays sliced off at top edge in large size text mode
: Asian UTF-8 displays sliced off at top edge in large size text mode
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Display
: 7.0
: PC Linux (other)
: P2 normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-20 21:53 UTC by quiet.dragon
Modified: 2008-12-18 11:12 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Small text size showing characters without clipping (716.90 KB, image/jpeg)
2008-01-21 17:17 UTC, quiet.dragon
Details
Large text size showing characters clipped on top edge (727.56 KB, image/jpeg)
2008-01-21 17:18 UTC, quiet.dragon
Details
Tar ball with UTF-8 characters in directory name as per jpegs (10.00 KB, application/octet-stream)
2008-01-21 17:21 UTC, quiet.dragon
Details
displaying with reduced font size (20.89 KB, image/jpeg)
2008-01-25 01:04 UTC, Michael Herger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description quiet.dragon 2008-01-20 21:53:40 UTC
When browsing to the Music Folder, albums with names in Asian UTF-8 are rendered, but have
their pixels sliced off at the top edge.

For example:   周華健/光陰似健 1987 - 1997

This will have the lines along the top edge sliced off.
Comment 1 Michael Herger 2008-01-21 05:14:00 UTC
could you please provide us with a photo or something?
Comment 2 quiet.dragon 2008-01-21 09:57:52 UTC
(In reply to comment #1)
> could you please provide us with a photo or something?
> 

I was thinking this very thought this morning. I'll organise something appropriate.
Comment 3 quiet.dragon 2008-01-21 17:17:50 UTC
Created attachment 2697 [details]
Small text size showing characters without clipping
Comment 4 quiet.dragon 2008-01-21 17:18:32 UTC
Created attachment 2698 [details]
Large text size showing characters clipped on top edge
Comment 5 quiet.dragon 2008-01-21 17:21:16 UTC
Created attachment 2699 [details]
Tar ball with UTF-8 characters in directory name as per jpegs
Comment 6 quiet.dragon 2008-01-21 17:22:16 UTC
> I was thinking this very thought this morning. I'll organise something
> appropriate.

I've created a bunch of attachments. The pictures show the effect, and the
tar ball contains a dummy file in a directory whose name matches the
directory name shown in the images.
Comment 7 Michael Herger 2008-01-25 01:04:50 UTC
Created attachment 2725 [details]
displaying with reduced font size

Earl - here's a screenshot with the following patch applied. I don't know whether this is "fixed" or just improved. Please feel free to play with the following patch:

Index: /Users/mh/Documents/workspace/SC7.0/Slim/Display/Lib/Fonts.pm
===================================================================
--- /Users/mh/Documents/workspace/SC7.0/Slim/Display/Lib/Fonts.pm	(revision 16744)
+++ /Users/mh/Documents/workspace/SC7.0/Slim/Display/Lib/Fonts.pm	(working copy)
@@ -111,8 +111,8 @@
 
 	# Huge - only one line.
 	'full.2' => {
-		'GDFontSize' => 26,
-		'GDBaseline' => 25,
+		'GDFontSize' => 24,
+		'GDBaseline' => 26,
 	},
 

This seems to be working. But you might want to tune the values a bit to lower the string to increase the size again. What values would you recommend using?
Comment 8 Michael Herger 2008-01-25 01:05:44 UTC
The Baseline could be as low as 31, but it then probably looks a bit misaligned with western text. Please play with it. Thanks!
Comment 9 Blackketter Dean 2008-01-25 22:46:55 UTC
Earl: is this fixed for you?
Comment 10 quiet.dragon 2008-01-26 08:20:23 UTC
(In reply to comment #9)
> Earl: is this fixed for you?

Sorry, I was busy Friday night. I'll get time to try this out this weekend.
Comment 11 quiet.dragon 2008-01-26 17:11:42 UTC
(In reply to comment #9)
> Earl: is this fixed for you?

Yes, the fix looks good.
Comment 12 Michael Herger 2008-01-26 22:08:59 UTC
Great, thanks for the feedback!

Change 16791 - add some pixels in height when rendering TT fonts in full screen mode
Comment 13 Chris Owens 2008-03-07 09:04:35 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.