Bug 6653 - a menu item style that does not include an icon should not display an icon
: a menu item style that does not include an icon should not display an icon
Status: CLOSED INVALID
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: Macintosh Other
: P2 normal (vote)
: 7.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks: 6679
  Show dependency treegraph
 
Reported: 2008-01-18 13:18 UTC by Ben Klaas
Modified: 2009-09-08 09:24 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
picture of messed up UI menu (53.32 KB, image/png)
2008-01-18 13:19 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2008-01-18 13:18:17 UTC
If a skin style explicitly does not include an icon in it's group order, no icon should be displayed.

I had some code in SlimBrowser to display radio icons in certain contexts, but it kills the UI elsewhere.

this is the SlimBrowser lua code I'm commenting out. It's possible my elseif could be modified to target only the item I'm looking for, but really the skin should not barf out icons if they aren't desired in that style.

 elseif item["params"] and item["params"]["track_id"] then
                if menuAccel and not _server:artworkThumbCached(item["params"]["track_id"], 56) then
                        -- Don't load artwork while accelerated
                        _server:cancelArtwork(icon)
                else
                        -- workaround: this needs to be png not gd because in gd it looks like garbage
                        _server:fetchArtworkThumb(item["params"]["track_id"], icon, _artworkThumbUri, 56, 'png')
                end
Comment 1 Ben Klaas 2008-01-18 13:19:16 UTC
Created attachment 2687 [details]
picture of messed up UI menu

the reason these icons are fetched is because it hit the elseif block of SlimBrowser mentioned in the first comment to this bug
Comment 2 Blackketter Dean 2008-01-18 14:32:07 UTC
Ben/Richard: who should fix this?
Comment 3 Ben Klaas 2008-01-18 14:41:01 UTC
I'm not sure whether this is in the C code or Lua code, and I've wasted too much time on it already. FYI, this is a 7.0.1 target bug.

Bummer, because I had to pull out the code that allowed for the radio icon to show up in playlists.
Comment 4 Blackketter Dean 2008-01-20 08:26:14 UTC
Richard: can you give ben some advice on this?
Comment 5 Richard Titmuss 2008-01-20 11:29:39 UTC
Stealing this into my list, Ben I am not sure exactly what the problem is here. I'll be asking you about this sometime next week.
Comment 6 Richard Titmuss 2008-01-23 08:01:13 UTC
After a discussion with Ben this bug is now invalid, the problem was solved another way.
Comment 7 James Richardson 2008-08-12 11:11:52 UTC
Marking resolved bugs as closed.

Please reopen if the issue has not been addressed fully.