Bug 6618 – Script error in default skin - titles with apostrophe

Bug 6618 - Script error in default skin - titles with apostrophe

Summary:

Script error in default skin - titles with apostrophe

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Skins
Version:	7.0
Platform:	PC Windows Vista

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Unassigned bug - please assign me!

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-01-14 21:40 UTC by Hugh Pyle
Modified:	2008-01-15 07:56 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hugh Pyle 2008-01-14 21:40:20 UTC

With albums containing apostrophe (') in their name, the new default skin's Favorite handling causes a script error.

For example,
<a href="javascript:void(0);" onClick="Utils.toggleFavorite(this, 'db%3Aalbum.titlesearch%3DELLA%2520AT%2520DUKE%2520S%2520PLACE', 'Ella%20at%20Duke's%20Place')" ><img src="/html/images/b_favorite.gif" class="cmdLinkIcon" width="17" height="17" alt="Add to Favorites" title="Add to Favorites"/></a>

The apostrophe in "Ella at Duke's Place" is not escaped.  This causes "Expected ')'" script error as it parses the rest of the line.

Comment 1 KDF 2008-01-15 00:55:40 UTC

need more details here.  what's the url of the page?  this same you posted cannot be found in any of the current source code.

Comment 2 Hugh Pyle 2008-01-15 05:06:18 UTC

Sorry, this is any of the ambum-list views (browsedb.html) in the default skin.  The source seems to be the "favoritescontrol" block of HTML/EN/cmdwrappers.

Comment 3 Hugh Pyle 2008-01-15 05:27:02 UTC

(and this is SqueezeCenter_trunk_v2008-01-14 nightly, Windows.  In IE7 with "disable script debugging" turned off)

Comment 4 Michael Herger 2008-01-15 07:56:17 UTC

change 16308 - successfully tested with artist "Fool's Garden" and album "Sgt.Pepper's Lonely Hearts Club Band"

Please re-open if this doesn't fix the issue for you. Thanks!