Bug 6610 - Time Format and Date/Time Screensaver
: Time Format and Date/Time Screensaver
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Display
: unspecified
: All All
: P2 enhancement (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-14 04:44 UTC by Peter DeBrass
Modified: 2009-07-31 10:15 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter DeBrass 2008-01-14 04:44:34 UTC
Hi,

As the SqueezeBox Duet and 3 are now being pushed more to a global audience, maybe it is time to revise how the time format and the date/time screensaver displays the time. 

Most of world does not use the 12h hour format, but a 24h format, maybe it would be a good idea to do the following:

1. Let the customer choose the time format while installing or let it get auto-detected during setup.
2. Change the Date/Time Screensaver to use the use the option "SqueezeCenter Default", which will then take the time format previously configured during installation.


Regards, Peter
Comment 1 KDF 2008-01-14 08:23:14 UTC
this should take care of making SC Default as the default for the screensaver.

Index: 7.0/server/Slim/Plugin/DateTime/Settings.pm
===================================================================
--- 7.0/server/Slim/Plugin/DateTime/Settings.pm	(revision 16243)
+++ 7.0/server/Slim/Plugin/DateTime/Settings.pm	(working copy)
@@ -13,8 +13,8 @@
 my $prefs = preferences('plugin.datetime');
 
 $prefs->migrate(1, sub {
-	$prefs->set('timeformat', Slim::Utils::Prefs::OldPrefs->get('screensaverTimeFormat') || '|%I:%M %p');
-	$prefs->set('dateformat', Slim::Utils::Prefs::OldPrefs->get('screensaverDateFormat') || '%A, %B |%d, %Y');
+	$prefs->set('timeformat', Slim::Utils::Prefs::OldPrefs->get('screensaverTimeFormat') || '');
+	$prefs->set('dateformat', Slim::Utils::Prefs::OldPrefs->get('screensaverDateFormat') || '');
 	1;
 });
 
Comment 2 Blackketter Dean 2008-01-14 10:19:05 UTC
Michael to look at this simple fix for 7.0, but will continue with larger internationalization issues for 7.1.
Comment 3 Michael Herger 2008-01-14 10:29:59 UTC
Peter - I'm glad you're coming up with this topic. I think we should include a set of reasonable presets for 7.1. Do you see other potential candidates as language/regional preset? The formatting could eg. be done in function of the language setting during the setup wizard.
Comment 4 Peter DeBrass 2008-01-14 23:39:48 UTC
Hi Michael,

No the Time Format is the biggest concern I have with regards to globalization of SB3 and Duet. The other one is the used short and long date format, mainly the formatting of these.

There are not really that many other issues, that are transparent to the customers, as much as the date and time formatting are.

/Peter
Comment 5 Michael Herger 2008-01-15 08:41:54 UTC
above patch is checked in as change 16310

My first idea was to initialize the values depending on the language setting. Problem is, prefs are initialized long time before the language is chosen. Would have to overwrite the prefs during the wizard or something, as we then can assume the settings are still "fresh". And probably only replace if the previous value was still the default value. Will have to think more about this.
Comment 6 Michael Herger 2008-01-16 02:11:03 UTC
Will look at this for the 7.1 release.
Comment 7 Michael Herger 2008-02-07 07:33:19 UTC
*** Bug 6996 has been marked as a duplicate of this bug. ***
Comment 8 Michael Herger 2008-04-23 02:27:58 UTC
change 19065 (SC7.1) - localize default date/time formats during setup wizard. 

Please note that the settings won't be changed if the language is switched using the basic settings page, as we don't want to overwrite custom selections.

Feel free to re-open if you see more settings we should try to localize automatically.
Comment 9 Chris Owens 2008-07-30 15:30:17 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 10 Chris Owens 2009-07-31 10:15:53 UTC
Reduce number of active targets for SC