Bug 6590 - Window menuStyle does not affect current window, only children
: Window menuStyle does not affect current window, only children
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P2 major (vote)
: 7.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-12 08:20 UTC by Andy Grundman
Modified: 2009-09-08 09:30 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
example of setStyle to menu style 'albumitem' not working (68.87 KB, image/png)
2008-01-18 20:39 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-01-12 08:20:24 UTC
Setting a menuStyle only affects child windows, not the current window.

This needs to be fixed for 7.0 or XMLBrowser lists (Rhapsody albums, etc) cannot have artwork, because it would mean all XMLBrowser menus would have to use the album menuStyle and it will look bad.
Comment 1 Ben Klaas 2008-01-18 15:42:39 UTC
Fixed in r1507.

Allow a window.menuStyle parameter to be sent over when creating a new menu. 
window.menuStyle should set the menu's style and override whatever it's set to.

in SC, you can add this to the request response to set this style
 $request->addResult('window', { menuStyle => 'album' });
Comment 2 Ben Klaas 2008-01-18 20:37:45 UTC
Doesn't seem to be fixed correctly yet.

Richard, I'm going to assign this to you because I think this may need fixing in the C code.

Here's the issue as I see it.

When a SlimBrowser menu is requested, a windowSpec is sent. At that time, the window parameters in SlimBrowser._newDestination are set, including a Menu style. 

Then the new window is populated with the response from SqueezeCenter, which now may include a menuStyle intented for the current window. I have been trying to use Widget.setStyle() on the menu at this time, but it appears that Widget.reSkin(), called from Widget.setStyle() does not work properly, particularly with reordering items across the line.


Comment 3 Ben Klaas 2008-01-18 20:39:09 UTC
Created attachment 2688 [details]
example of setStyle to menu style 'albumitem' not working
Comment 4 Richard Titmuss 2008-01-23 07:49:40 UTC
Fixed in SC change 16649 and Jive r1586.
Comment 5 James Richardson 2008-05-15 13:01:28 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html