Bugzilla – Bug 6556
'Various Artists' replaces real Artists at various points in the Browse Artist List
Last modified: 2009-09-08 09:23:16 UTC
r1279 When Browsing Artists, in addition to the normal 'Various Artists' entry, other (seemingly random) Artist names are replaced by 'Various Artists' eg Web UI:- .. Talk Talk Talking Heads Talvin Singh Tanita Tikarum Tasmin Archer .. Jive UI:- .. Talk Talk Talking Heads Various Artists Tanita Tikarum Tasmin Archer .. Selecting the erroneous 'Various Artists' appears to give a list of the VA albums, making (in this case) Talvin Singh's Album inaccessible via browse Artists on Jive
Patrick, I've never seen this. Is it repeatable? Can you get network.comet logs from SC when it happens. Thanks.
Yes completely repeatable. I have 6 or 7 'Various Artists' in my list, each (apart from one) replacing a valid artist which I can't therefore access. I know which artists by comparing to the browse artist list on the Player and Web UIs - so it has to be a Jive issue. What's a network comet log? It happens all the time - they're just there in the list, so when would I take the log? I'm pretty sure someone else reported it on the forums a while back - so it's not a new thing.
see this post:- http://forums.slimdevices.com/showthread.php?t=38915
Thanks Patrick, this should be fixed for 7.0. Ben do you see this, or do we need to get logs from someone. I assume it's a SC problem, but the logs could prove this.
*** Bug 6809 has been marked as a duplicate of this bug. ***
Michael: can you help out ben on this?
Does any of your Counting Crows tracks fall into a VA album? If you connect to the CLI (telnet localhost 9090) and run the "artists 0 9999" query, do you see the same issue? As Richard mentioned, network.comet might be interesting.
On my system, this occurred with artists that both did and did not have entries in VA albums. AFAIKT, the telenet CLI command only produces a single VA entry at the start of the list.
Ahm... any logs? They could really be helpful.
Nothing shows in the logs. What can I tell you ... ? Get a Jive, a music library, run SC7 and it should be easily reproduceable I reckon. It's a PITA scrolling through 900-odd Artists, but I see several instances of it in my setup.
If you want to connect here, email me and I'll give you ssh access to my server.
Did you enable network.comet logging? This is _very_ chatty and should produce tons of output. Mail is on its way. Thanks.
Created attachment 2764 [details] log with network.comet enabled
Ouch... it's really easily reproduceable: VA are part of _every_ resultset to the "artists" request. Thus they show up whenever Jive is fetching another bunch of items. By default it's every 200th item. By reducing that number to 20 I did see it as well (don't have 200 artists in my testing environment).
Patrick - does the following change fix this issue for you? Index: /Users/mh/Documents/workspace/SC7.0/Slim/Control/Queries.pm =================================================================== --- /Users/mh/Documents/workspace/SC7.0/Slim/Control/Queries.pm (revision 16883) +++ /Users/mh/Documents/workspace/SC7.0/Slim/Control/Queries.pm (working copy) @@ -614,7 +614,8 @@ # Various artist handling. Don't do if pref is off, or if we're # searching, or if we have a track - if ($count_va) { + if ($count_va && $start == 0) { + unshift @data, Slim::Schema->variousArtistsObject; } IMHO we should return the VA item only with the first slice ($index == 0), not with every subsequent slice again.
That seems to solve the extra VA problem for me, but I now have another issue that I don't think I had before - I can't scroll down to the bottom of the Artists list (I get to the last W, and can see "XTC" but can't get to it or any of the Zs). If I wrap round from the top, the scroll wheel dies in the Zs and I have to use the home key to get out.
Created attachment 2765 [details] fix artist browsing Please give this a try, thanks! Ben - I'm not sure about the magic involved when adjusting the $index for the last chunk only. If I do this for all chunks>0, Jive would loop. For some odd reason Jive is already requestion an index-1 what I would expect. Except for the last item - thus I added the correction there. But it's all a bit fuzzy to me.
Michael fixed this in SC change 16901. If you can verify the fix, Patrick, it would be much appreciated.
Unfortunately I am unable to test, because having updated to SqueezeCenter Version: 7.0 - 16880 - Debian - EN - utf8 it has hosed all my settings, is rescanning my library and Jive is stuck on the begin update screen. Pressing the centre button does nothing, so I'm unable to access the browse screen. Jive is r1658
OK, I'm back up and running now after reverting back a Jive fw version. Looks good - well done Michael! I'm not 100% sure if there are any missing Artists as the scan used the default setting and I have millions more Artists now (from all the VA albums) :-), but it looks good AFAICS.
Patrick, your patience is exceptional. I know we're in beta, but you've been really put through the ringer here. Glad to hear you haven't been reduced to tears. Or maybe you have, it's hard to tell in a virtual world. :)
No problem! I've spent many years in product development, so I know how it works (and sometimes doesn't). I'm happy I could help :-)
BTW: your server.log is _huge_ and has tons of the network.comet stuff in there. Make sure you turn it off again.
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html