Bug 6504 - menu style like 'album' but with smaller icons
: menu style like 'album' but with smaller icons
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Other
: P2 enhancement (vote)
: 7.1
Assigned To: Ben Klaas
:
Depends on: 8479
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-30 06:54 UTC by Peter Watkins
Modified: 2008-12-15 12:38 UTC (History)
0 users

See Also:
Category: ---


Attachments
small icon style screenshot (51.70 KB, image/png)
2008-06-18 13:45 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Watkins 2007-12-30 06:54:08 UTC
Opening an enhancement ticket as suggested by Dean...

It would be nice to have a menu style that allowed small icons. Using 52x52 with lists that only have short text phrases makes the lists take up much more vertical space. See the "Bedroom lights" screenshot on
http://forums.slimdevices.com/showthread.php?t=41482
With icons by each line, the JHB screen will only show "On" through "20%". Also, even for a 4-item list like "Kitchen lamp", the list looks too spaced out with 52x52 icons.

I didn't think of this before, but I guess I'd like a small icon list option much like the theme I use on my Rockboxed iPod Video: http://www.rockbox.org/twiki/pub/Main/WpsIpod5g/Simplex2_b-1.1.png -- it dresses up the simple list and makes it a little nicer to use.
Comment 1 Blackketter Dean 2007-12-31 08:50:51 UTC
Let's look at this soon.
Comment 2 Peter Watkins 2007-12-31 12:02:12 UTC
There's been some speculation on the forums about the next generation devices, and requests for things like larger fonts for Jive when Jive is running on a regular desktop.
Along those lines, it'd be nice to have a Perl API for determining things like the current Jive display's font size / line height in pixels, line width in pixels, the color depth of the display, etc.
Then plugins could choose which icon image to use.
It'd also be nice if the new Jive menu style would (1) not scale the icon, but use the greater of icon height or text/font height to determine vertical spacing and (2) word wrap the text if the icon is tall enough to fit 2 or more lines of text next to it (maybe Jive already does this).
Comment 3 Ben Klaas 2008-06-06 08:54:53 UTC
I'm going to try to tackle this for 7.1
Comment 4 Ben Klaas 2008-06-18 13:45:13 UTC
Created attachment 3456 [details]
small icon style screenshot

I've added a "smallicon" style to DefaultSkinApplet.lua, but note that this is not a full fix yet because SlimBrowserApplet.lua hard-codes the thumbnail size to 56 pixels. There's another bug open on that, so I'll mark this one as dependent on that one.

here's a code snippet of what I did to send the necessary directives to style the menu items in the new style:

$request->addResultLoop('item_loop', $count, 'style', 'smalliconitem');
$request->addResultLoop('item_loop', $count, 'icon-id', '/html/images/favorites.png');
Comment 5 Ben Klaas 2008-06-18 13:49:07 UTC
hmmm...perhaps there isn't a bug open on the artwork size issue. I'll open one.
Comment 6 Ben Klaas 2008-06-23 08:39:30 UTC
a couple bug fixes in r2616, and that should bring this style to completion

smalliconitem is now available, as well as smalliconitemNoAction (same as smalliconitem, but no > on the right when item is selected in menu)

code example for adding this style to a menu item:
$request->addResultLoop('item_loop', $count, 'style', 'smalliconitem');
$request->addResultLoop('item_loop', $count, 'icon-id', '/html/images/favorites.png');

note that you can't mix line heights within a menu (at least right now you can't), so smalliconitem can be used on the same menu with 'item' style, but not in the same menu with the 'albumitem' style.
Comment 7 Chris Owens 2008-07-30 15:28:46 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 8 James Richardson 2008-12-15 12:38:06 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.