Bug 642 - make it so that the trailing slash on URL when accessing a different skin is not mandatory
: make it so that the trailing slash on URL when accessing a different skin is ...
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: All All
: P2 enhancement (vote)
: ---
Assigned To: Vidur Apparao
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-02 11:01 UTC by Kevin Pearsall
Modified: 2008-12-18 11:53 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2004-11-02 11:01:20 UTC
I've spoken with quite a few folks who don't get why you need a trailing slash
when specifying the skin.  Some people also get confused by the case sensitivity...

Not sure if omitting the slash would violate rfc 1738, since if you're
specifying a hierarchy you're supposed to use a /...
Comment 1 Blackketter Dean 2004-11-02 13:40:06 UTC
Simple patch to fix this:

Index: Slim/Web/HTTP.pm
===============================================================
====
RCS file: /home/cvs/cvsroot/slim/server/Slim/Web/HTTP.pm,v
retrieving revision 1.122
diff -r1.122 HTTP.pm
358c358,361
< 
---
> 
>                       # paths that are pure alpha without a trailing slash get a slash added, to make skins 
easier to find
>                       $path =~ s|^/([a-zA-Z]+)$|/$1/|;
> 

Vidur, you good with this for 5.4?
Comment 2 Blackketter Dean 2004-11-08 10:32:04 UTC
Fixed for next nightly release.
Comment 3 Chris Owens 2006-06-16 14:42:24 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.
Comment 4 Chris Owens 2008-12-18 11:53:42 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.