Bug 6372 - Scanner including hidden directories
: Scanner including hidden directories
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.0
: PC Linux (other)
: P2 normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-15 05:30 UTC by Jeff Christoffersen
Modified: 2010-03-08 21:00 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
Scanner log (1003.88 KB, text/plain)
2007-12-18 04:09 UTC, Jeff Christoffersen
Details
unify BMF & scan filters (5.00 KB, text/plain)
2007-12-19 05:43 UTC, Michael Herger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Christoffersen 2007-12-15 05:30:43 UTC
Scanner appears be be including hidden directories in its scan, including the .AppleDouble directory.  This is causing bogus entries to appear within SqueezeCenter.
Comment 1 Michael Herger 2007-12-17 00:48:58 UTC
Dot files should be excluded on any platform (Slim::Utils::Misc::readDirectory()). Are you sure these are included in your case? Could you please provide us with a scanner log file?
Comment 2 Jeff Christoffersen 2007-12-18 04:09:23 UTC
Created attachment 2539 [details]
Scanner log
Comment 3 Jeff Christoffersen 2007-12-18 13:42:01 UTC
See attached log.  Many examples of .AppleDouble directory reads.  
Comment 4 Michael Herger 2007-12-19 05:24:14 UTC
The scan seems to use a different set of filters than Browse Music Folder - resulting in different files being indexed. That's no good. Will look into unifying this.
Comment 5 Michael Herger 2007-12-19 05:43:27 UTC
Created attachment 2546 [details]
unify BMF & scan filters
Comment 6 Michael Herger 2007-12-19 05:51:59 UTC
change 15460 - please test
Comment 7 Jeff Christoffersen 2007-12-20 19:18:23 UTC
I updated tp 12-20 trunk then ran scan and noted totals.  Replaced Misc.pm and Scanner.pm with files from change.  Did a clear and rescan.  Results were the same.  The .AppleDouble files are still appearing.
Comment 8 Michael Herger 2007-12-21 01:06:04 UTC
The previous "fix" indeed didn't fix the filter applied when descending folders, sorry. Change 15528 hopefully does better.

Could you please try again?
Comment 9 Jeff Christoffersen 2007-12-21 04:57:50 UTC
That appears to have fixed the problem.  The AppleDouble directories are no longer appearing.
Comment 10 Michael Herger 2007-12-21 05:03:47 UTC
Great, thanks! Feel free to re-open if needed.
Comment 11 Jim McAtee 2008-02-11 19:26:33 UTC
I spent a little time today trying to figure out why my SqueezeCenter 7 server shows one fewer album and nine fewer tracks than my SlimServer 6.5.5 server.

The missing album is Metallica's "...And Justice for All", with the album folder name beginning with three dots.  Is SC7 maybe thinking that this is intended to be a hidden folder?  It doesn't show up when I browse the Music Folder either.

The server is running on Windows. Could the change in behavior on Windows be related to the changes made for this bug?
Comment 12 Michael Herger 2008-02-11 20:55:31 UTC
Slim::Utils::Misc line 850. We should probably exclude that filter for Windows systems.
Comment 13 Michael Herger 2008-02-12 14:43:58 UTC
change 17472 - allow dot files in Windows
Comment 14 Jim McAtee 2008-02-12 20:34:33 UTC
That did the job.  Thanks Michael.
Comment 15 Chris Owens 2008-03-07 09:04:29 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.
Comment 16 Chris 2010-03-08 18:01:30 UTC
Hello. I'm new to bugzilla so excuse my ignorance. I'm using squeezeserver v7.4.2, r30215, Fri Feb 19 15:21:27 PST 2010) on perl 5.10.0.

The problem I see is that the album "Metallica ...And Justice for All" does not scan. The "..." is in both the directory name and the mp3 tags. I haven't tried to debug this, simply searched the web and saw this as closed. Seems pretty straight forward. 

The simple workaround is to rename the album and rewrite the tags w/o the "..." (do both need to be done?). 

Not sure of the etiquette here, if you want me to open a new bug I guess I could.
Comment 17 Chris 2010-03-08 18:19:54 UTC
Btw, a "better" workaround is to 'mv "...And Justice for All" " ...And Justice for All"'. The space is hardly noticeable in the gui and somewhat preserves the album name. 

Also, Linux butterbox 2.6.26-2-686 #1 SMP Thu May 28 15:39:35 UTC 2009 i686 GNU/Linux
Comment 18 Michael Herger 2010-03-08 21:00:30 UTC
No need to change any tags. But the leading dot in a file/folder name will make it hidden on Unixy file systems, thus is ignored. Thus you only need to change the file/folder name.