Bug 6328 - Music on Demand+Internet Radio no album artwork
: Music on Demand+Internet Radio no album artwork
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: All Other
: P5 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-11 18:02 UTC by ndijulio
Modified: 2009-09-08 09:16 UTC (History)
0 users

See Also:
Category: ---


Attachments
Service Provider no artwork icon example (55.40 KB, image/png)
2007-12-11 18:04 UTC, ndijulio
Details
Internet Radio-generic icon artwork (28.19 KB, image/png)
2007-12-20 10:02 UTC, ndijulio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ndijulio 2007-12-11 18:02:47 UTC
When you are listening to either music on demand or internet radio the default icon [when no album artwork is available] should be the logo for that service provider.  For instance when listening to Rhapsody, the s.p. badge/logo would appear in place of the Jive, "no album icon."

I will attach reference artwork...
Comment 1 ndijulio 2007-12-11 18:04:12 UTC
Created attachment 2503 [details]
Service Provider no artwork icon example
Comment 2 Richard Titmuss 2007-12-12 08:38:19 UTC
Ben I'm not sure how easy this will be?
Comment 3 KDF 2007-12-12 09:50:01 UTC
not easy.  for radioio, the url at least indicates the provider.  But, shoutcast is just a list of radio sites.  The provider would have to be a tracked parameter.  We'd have to always know how the playback originated, which would be problematic if a url is stored as a favourite or a playlist.
Comment 4 Ben Klaas 2007-12-12 09:58:26 UTC
What if we did a "best effort"? For URLs that could be identified as coming from a particular provider (RadioIO, Rhapsody, Pandora), we use their artwork. Otherwise we fall back to the radio tower icon (we don't even do that right now)

Although on further thought...I really don't want to go down the fuzzy path of trying to match providers with obscure and diverse URLs.

It'd be really nice to have provider-specific default icons though...I'd like to figure out a way to do this.
Comment 5 KDF 2007-12-12 11:13:29 UTC
place a reference in the protocol handler maybe? If it goes through a specific one, then alter the icon. Anything through the generic handler just gets the radio tower
Comment 6 KDF 2007-12-12 11:15:32 UTC
actually...don't we already do something along these lines? 
Look at getMetaDataFor (Live365::ProtocolHandler for eg).  There is a cover reference there.
Comment 7 Blackketter Dean 2007-12-20 06:54:26 UTC
To reemphasize something that Ben said in comment 4:

In the case that it's a radio station without a specific logo, the cover art should be a radio station icon, not a note symbol icon.

Noah:  Do we have a generic radio icon inside a square?  if not, we'll need one.
Comment 8 ndijulio 2007-12-20 09:59:21 UTC
We do have a internet radio icon.  The original artwork was sent out 9/27/07, however, I reformatted the icon to be the same as the service provider logos.  Let me know if you need the drop shadow removed. Please see attached png.
Comment 9 ndijulio 2007-12-20 10:02:53 UTC
Created attachment 2553 [details]
Internet Radio-generic icon artwork

The attached artwork is similar to the context of no album artwork, but for internet radio stations.
Comment 10 Ben Klaas 2007-12-20 13:10:52 UTC
This is mine to fix, though not at the top of my list
Comment 11 Ben Klaas 2007-12-26 08:58:11 UTC
Target 7.0/priority P5
Comment 12 Ben Klaas 2008-01-03 21:24:58 UTC
Fixed in r1310
Comment 13 James Richardson 2008-05-15 13:00:48 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html