Bug 6301 - Slim::Player::HTTP missing methods?
: Slim::Player::HTTP missing methods?
Status: RESOLVED INVALID
Product: Logitech Media Server
Classification: Unclassified
Component: Streaming From SlimServer
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-09 04:29 UTC by James Craig
Modified: 2007-12-09 06:06 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2007-12-09 04:29:11 UTC
The $client object generated for a 'stream.mp3' from connection seems to be incorrectly setup. 

For example it returns false for the isPlayer() method and cannot generate strings.

In this thread on the forums:
http://forums.slimdevices.com/showthread.php?t=40925
Triode said:
"It occurs because Slim::Player::HTTP inherits from Slim::Player::Client and not Slim::Player::Player and hence doesn't get the mappings from client methods to display methds in Player::Player.

Easy fix to include a few lines from Slim::Player::Player in Slim::Player::HTTP, possibly needs more than strings though."
Comment 1 Michael Herger 2007-12-09 05:04:08 UTC
That's all by design:

- isPlayer=0: doesn't speak slimproto, can't be synchronized
- $client->string(): doesn't return a value, as a http client doesn't have a display to show strings on
Comment 2 James Craig 2007-12-09 06:06:29 UTC
So 'isPlayer' should actually be called 'canSyncronize'?

I'm also getting errors like this in the log, probably when something tries to generate the song name for the stream meta-information. 

[00:38:03.8034] Slim::Control::Request::execute (1719) Error: While trying to run function coderef [Slim::Control::Comma
nds::playcontrolCommand]: [Can't locate object method "currentSongLines" via package "Slim::Player::HTTP" at C:/Program
Files/SlimServerSVN/server/Slim/Control/Commands.pm line 499.

And the lack of strings is a bit annoying in settings handlers.