Bug 6295 – Choose local music folder failed when I accidentally tried to expand a dvd drive

Bug 6295 - Choose local music folder failed when I accidentally tried to expand a dvd drive

Summary:

Choose local music folder failed when I accidentally tried to expand a dvd drive

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Setup
Version:	7.0
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-12-08 02:52 UTC by Gareth Hughes
Modified:	2008-12-18 11:12 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gareth Hughes 2007-12-08 02:52:02 UTC

First try of SC beta.
It's SqueezeCenter_trunk_v2007-12-08.exe


Wasn't sure which drive to use for my local music folder as I have 8 so I clicked the + icon next to D and the web ui stopped.
The machine running SC is now showing the windows error-
"There is no disk in the drive. Please insert a disk into drive D:"

etc

I guess this needs to be caught.

What might make it easier for the user would be to show different icons for different drive types on the web UI. E.g a kind of CD icon for those type of drives.

cheers

Comment 1 KDF 2007-12-08 14:21:55 UTC

was this actually a crash, or were you simply interrupted by the popup alert?

Michael, didn't we have something already in place for cases like this?

Comment 2 Michael Herger 2007-12-08 19:56:59 UTC

Yes, we've seen this before, with floppy drives. The simplistic "fix" I did was excluding drives A: & B: from the list.

I should probably use Win32::DriveInfo::isReady() instead.

Comment 3 Michael Herger 2007-12-08 20:57:05 UTC

change 15099 - check drive state before accessing it.

Gareth - I haven't been able to reproduce your issue. But I remember having seen it reported when a user had an empty medium in the drive. Can you please confirm this fix?

Comment 4 Gareth Hughes 2007-12-09 02:48:43 UTC

It wasn't a crash. The message box on the server stopped things. By the time I'd figured out what was going on the driver chooser in the browser was confused and I had to start again.
Strange that you couldn't reproduce it. All it took was to try and expand an empty dvd drive.
I'll try the build now.

Comment 5 Gareth Hughes 2007-12-09 02:50:04 UTC

I have now downloaded the new build and can confirm that the problem is fixed. Good stuff

Comment 6 Chris Owens 2008-03-07 09:04:28 UTC

This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.