Bug 6290 – Wrong menu ordering for shoutcast and podcasts

Bug 6290 - Wrong menu ordering for shoutcast and podcasts

Summary:

Wrong menu ordering for shoutcast and podcasts

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	7.0
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Unassigned bug - please assign me!

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-12-07 14:13 UTC by Mark Miksis
Modified:	2007-12-14 07:23 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
trivial patch (1.38 KB, patch) 2007-12-13 21:05 UTC, Mark Miksis	Details \| Diff
Fixed patch (1.16 KB, patch) 2007-12-13 21:12 UTC, Mark Miksis	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Miksis 2007-12-07 14:13:54 UTC

Shoutcast and podcasts seem to be grouped at the end with all the 3rd party plugins.

Shoutcast is sorted wrong because (I think), it is ranked with:
'rank-PLUGIN_SHOUTCAST_MODULE_NAME' => 5, (in Prefs.pm)
but it's really called PLUGIN_SHOUTCASTBROWSER_MODULE_NAME

Podcasts is not sorted at all because it does not have a rank defined (and is not included in Dean's hierarchy wiki page).

Comment 1 Michael Herger 2007-12-13 04:54:26 UTC

Which skin are you using? I have the same order as the wiki page, except that Podcasts are in Internet Radio instead of Extras.

Comment 2 Mark Miksis 2007-12-13 08:20:49 UTC

Michael, install a Radio plugin that sorts near the beginning of the alphabet (such as Alien) and you'll see what I mean.  Shout cast and Podcasts are sorted with the 3rd party plugins, not the bundled plugins.

Comment 3 Mark Miksis 2007-12-13 21:05:30 UTC

Created attachment 2529 [details]
trivial patch

See patch.  Note that moving Podcasts to Extras as per the wiki means that it's the only Extra with an icon.  Maybe Information Browser and SoftSqueeze need icons too?

Comment 4 Mark Miksis 2007-12-13 21:12:10 UTC

Created attachment 2530 [details]
Fixed patch

Comment 5 Andy Grundman 2007-12-14 07:23:51 UTC

Thanks, applied as change 15292.