Bugzilla – Bug 6224
Wallpaper current setting not shown, error dump when entering wallpaper applet
Last modified: 2007-12-06 16:09:13 UTC
The current setting is not shown when entering wallpaper applet. There is also an error dump: error in network pump: ...jive/applets/SetupWallpaper/SetupWallpaperApplet.lua:196: bad argument #1 to 'pairs' (table expected, got nil) stack traceback: [C 0x36138]: in function 'pairs' ...jive/applets/SetupWallpaper/SetupWallpaperApplet.lua:196: in function '_serverSink' ...jive/applets/SetupWallpaper/SetupWallpaperApplet.lua:143: in function 'func' This appears to be due to a lack of server-side wallpaper, but we should skip the function call if there is no artwork on the server. patch coming.
Created attachment 2445 [details] fix grab the proper setting so that we show the current one. also, make sure chunk also has chunk.data.item_loop before we call the _serverSink to add server wallpaper items.
covered by checkin 1002. Richard - 1002 needs merging to 7.0
it's seem my little additional in the patch really only grabs the server wide setting. Even after selecting a player specific wallpaper, I cannot go back into the wallpaper applet and get a selected radio button. My fix obviously got around that by using the global pref, so it's not a full solution. I'll update and try to test again with 1002.
ok, 1002 is still not showing the current setting. here are the contents of the settings.lua in that applet: settings = {}; settings["wallpaper"] = "sunrise.png"; settings["00:04:20:10:02:5b"] = "sunrise.png";
ok, it seems this is what is required post 1002 Index: jive/share/applets/SetupWallpaper/SetupWallpaperApplet.lua =================================================================== --- jive/share/applets/SetupWallpaper/SetupWallpaperApplet.lua (revision 1002) +++ jive/share/applets/SetupWallpaper/SetupWallpaperApplet.lua (working copy) @@ -97,7 +97,7 @@ self.currentPlayer = _getCurrentPlayer() - local wallpaper = self:getSettings()[currentPlayer] + local wallpaper = self:getSettings()[self.currentPlayer] self.server = self:_getCurrentServer() self.group = RadioGroup() I've added this at r1003 but it should probably also go into 7.0
right both 1002 and 1003 should go in 7.0 - leaving merge to Richard..
This is not needed in the 7.0 branch (which will soon be renamed). Marking as fixed.