Bug 6200 - Favorites: favorites code in Slim::Control::Jive doesn't support remote urls or windows paths correctly
: Favorites: favorites code in Slim::Control::Jive doesn't support remote urls ...
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P2 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-20 12:52 UTC by Ben Klaas
Modified: 2008-05-15 13:00 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2007-11-20 12:52:52 UTC
from developer's campfire--

Triode  	
Ben - your favorites code, I notice you are adding "file://" to convert the filename to a url. Not looked at where it is doing this, but we will need to avoid this for remote streams... can't we get the url from object->url, send it to jive and jive returns this to add a favorite?

Robin V. 	
I've been told that you need three slashes to be fully compliant with the rfc...

Ben K. 	
sure thing.
Ben K. 	
it does end up with three slashes

Robin V. 	
so that's ok :)

Triode 	
but its broken for remote streams?

Ben K. 	
fwiw, that favorites code is dormant now.

Ben K. 	
actually, it's not in use

Robin V. 	
nope, IIRC, it's file:///c:/ or file:////temp on unix paths, but I may be wrong

Triode 	
ok. I'm happy to help with the server side if you need any when you get round to it..

Ben K. 	
i will need to look at all of that whenever i get back to the favorites stuff.
Ben K. 	
thanks
Comment 1 Ben Klaas 2007-12-26 08:36:22 UTC
Favorites support is an important 7.0 fix. Priority P2
Comment 2 Ben Klaas 2008-01-25 14:46:05 UTC
adding favorites with correct URLs in Jive fully supported in change 16768
Comment 3 James Richardson 2008-05-15 13:00:21 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html