Bugzilla – Bug 6177
Favorites: need to confirm removal of favorites on SB/Transporter
Last modified: 2009-07-31 10:15:20 UTC
Because people often double-press with the remote, we should require them to confirm the deletion of a favorite, otherwise it can be lost accidentally. From within a favorite, pressing RIGHT should show: Favorite #1 (Go right to remove) Pressing right should show: Remove Favorite #1 Cancel > Scrolling down one should show: Remove Favorite #1 Remove > That way they have to go down to actually remove the favorite. Also note that "delete" should be replaced with "remove".
Been thinking about this a little bit and realized that the (Go Right To Delete) bit is ugly and unnecessary. Let's simplify things a bit. The item in the song info page should just say Favorite 2 > if it's already a favorite. (Note the missing # sign and the missing parenthetical). Going right: Favorite 2 Cancel > scroll down to see: Favorite 2 Remove Favorite > This should work the same in Jive as well as SC and SN on the player UI.
I've implemented this in change 15987 for TrackInfo, RemoteTrackInfo, and BrowseDB favorite areas.
Reopening as there is still Jive work to be done here, passing over to Ben.
edit summary for bug list organization
the jive-side of this bug is covered by bug#6818 *** This bug has been marked as a duplicate of 6818 ***
I don't like the implementation of this. On my top-level favorites menu, I get the following: Favorites (2 of 4) Radio 4 -> (Right) Radio 4 (1 of 3) Favorite -> I'm given no clue as to what pressing Right now will do. It would be much better if it said Delete Favorite. Worse, when I do press Right I get: Favorite Cancel -> What does this mean? There's no clue that there's another item to chose from and I have no idea what I'm cancelling as I wasn't told before entering this level. It should be: Favorites (2 of 4) Radio 4 -> (Right) Radio 4 (1 of 3) Delete Favorite -> (Right) Delete Favorite (1 of 2) OK (Down) Delete Favorite (2 of 2) Cancel I've also switched the order of the default action. It's mean to be a confirmation, so selecting Cancel by default seems odd.
Just read the very first line of the very first comment in this bug. ;-) Ok, Cancel should come before OK.
Dean we need a ruling on this behavior
First, the Favorite number/index should be separate from the delete function. I'm seeing Favorites (3 of 5) Black Cow hitting right, I see: Black Cow Favorite [2] right again shows: Favorite 2 Cancel --------------------- So, it should be: Favorites (3 of 5) Black Cow going right: Black Cow (1 of 3) Remove Favorite going right: Delete Favorite (1 of 2) Cancel or Delete Favorite (2 of 2) Delete management of the favorite number/preset should be separate.
per Andy's request
I've made the following change, anywhere the string 'Favorite' was used it now uses 'Remove from Favorites'. This was used because there was already an existing string for it. Let me know if it looks OK now. Chanage 20565.
This is much better now. However, if you select Remove From Favorites, the next two choices are Cancel and Delete Favorite. The use of Remove and Delete is inconsistent. As the heading of the confirm mode is already Remove From Favorites, it would probably be better if the two choices were simply Cancel and Remove. Additionally, the preset number is still displayed after the favorite name - it shouldn't be, according to Dean. For example, I have: FAVORITES (5 of 7) Graceland > (going right) GRACELAND (1 OF 3) Remove from Favorites [6] > (going right) REMOVE FROM FAVORITES 6 Cancel > The 6 is confusing, especially as it is in square brackets once and then just on its own. Better to just remove it. Reopening as the fix doesn't implement Dean's requested changes, as described above.
Max, can you just provide a patch that does what you want? Thanks.
Sorry, but I honestly do not have time right now - I'm devoting all my spare time to writing alarm stuff. Apologies if I've trod on your feet here, but I'm just trying to provide feedback on the UI in order to make it clearer and more consistent.
Dean, let's get a final word on this.
"Remove from Favorites [6]" should be changed to "Remove Favorite 6" "Delete Favorite" should be "Remove Favorite" Otherwise, I think the latest nightly is good.
"Remove from Favorites [6]" actually indicates it is hotkey #6, not favorite #6. So not every favorite will have this. Do you want: "Remove Favorite" for non-hotkey favorites. "Remove Favorite 6" for hotkey favorites.
"Delete Favorite" changed to "Remove Favorite" in change 20733.
Ugh, I hate the fact that we have two ways of numbering the favorites. I'd just remove the number from here, as it's ambiguous.
OK, favorites don't have numbers anymore because they can be anywhere in the favorites tree.
Fixed in change 20736.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC