Bugzilla – Bug 6163
no way for 3rd party plugins to add custom icons
Last modified: 2008-12-18 11:12:53 UTC
OPML-based radio plugins should have a means to add custom icons for use in both the web UI and on Jive. mine to fix in Slim::Web::Pages.pm this is the section that needs changing, around line 115: # do an OS-independent check for a readable image for my $dir ( Slim::Utils::OSDetect::dirsFor('HTML') ) { if ( -r catfile( $dir, qw/EN html images ServiceProviders/, $iconName ) ) { $additionalLinks{'icons'}->{$title}{'url'} = 'html/images/ServiceProviders/' . $iconName; $additionalLinks{'icons'}->{$title}{'icon'} = $iconName; last; } }
Created attachment 2421 [details] full patch for current items this goes above and beyond the rough patch in campfire. I've added the addPageLinks calls from the non-opmlbased subclasses and the SN and TuneIn hardcoed additions. This seems to now be at par with what exists, but now add the ability to use a call from any plugin to use any image. Given that plugin may use this API, it will be nice to have Jive automatically replace the .png with _56x56_p.png for the images as a standard.
merged to trunk at change 14817.
Additional changes to support this bugfix-- client-side now sets the icon resizing parameters, so it is now invalid to define your icon-id with the server-side resize params already in the path. that is, 'icon-id' => '/some/path/to/myicon_56x56_p.png', should now be, 'icon-id' => '/some/path/to/myicon.png', this is implemented in jive r929 and SC change 14820
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.