Bug 6162 – Nokia770 Skin: radio/mod page adds mod to radio list for all

Bug 6162 - Nokia770 Skin: radio/mod page adds mod to radio list for all

Summary:

Nokia770 Skin: radio/mod page adds mod to radio list for all

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Skins
Version:	7.0
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Unassigned bug - please assign me!

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-11-15 09:53 UTC by KDF
Modified:	2007-11-15 12:29 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
apply ordering and rework radio/mod menu to avoid modifying global radio hash (3.04 KB, patch) 2007-11-15 11:13 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2007-11-15 09:53:28 UTC

Steps:

Load Default skin, note contents of Internet Radio list
Load Nokia770 skin, click on radio icon, and wait for load of radio + music on demand page.
Return to Default skin, note contents of Internet Radio List now contains the MOD items.
Any skin home page will have these merged.

Problem likely stems from:
		[% linkHash = additionalLinks.radio %]
		[% linkHash.import(additionalLinks.music_on_demand) %]

This seems to have the ability to go back into the original additionalLinks hash in perl and modify it.

Comment 1 KDF 2007-11-15 11:13:25 UTC

Created attachment 2413 [details]
apply ordering and rework radio/mod menu to avoid modifying global radio hash

for Ben's approval and testing on a real Nokia770/800

Comment 2 KDF 2007-11-15 11:18:24 UTC

Ben, I don't wnat to commit this one without your views, or more importantly a test on the actual device

Comment 3 Ben Klaas 2007-11-15 12:29:41 UTC

Looks fine so I just went ahead and checked it in. change 14755