Bug 6124 - Zero size playlists should have a single menu item that says 'Nothing'
: Zero size playlists should have a single menu item that says 'Nothing'
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Other Other
: P2 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-11 05:55 UTC by toby
Modified: 2009-09-08 09:21 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
always move the current playlist, even if it is empty (764 bytes, patch)
2007-11-11 05:56 UTC, toby
Details | Diff
screenshot of playlist window when playlist is empty (51.45 KB, image/png)
2008-01-21 13:40 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description toby 2007-11-11 05:55:31 UTC
I am in the habit of pressing "Now Playing" then "left" to return to a known position in the top level menu.

This behaviour is handy. For example, from muscle memory I can press "Now Playing", "left", "up", "right" to get to the slimscrobbler entry on my plugins menu. (this exact sequence depends on my personal menu layout, of course)

ptorpey on the general forum asked whether there is sequence of remote button presses which will always sign off slimserver. http://forums.slimdevices.com/showthread.php?t=40136. This would be useful for partially sighted users. He could use this too.....


....except that it doesnt always work. If the current playlist is empty then the "Now Playing" remote button leaves your menu position unchanged. 


Patch to follow.
Comment 1 toby 2007-11-11 05:56:24 UTC
Created attachment 2398 [details]
always move the current playlist, even if it is empty
Comment 2 KDF 2007-12-05 10:20:55 UTC
I've been thinking about this. It actually makes some sense to do this (although the patch needs some tweaking). Jive allows entry into the now playing screen also when playlist is empty.  consistency is the reasoning.  Right now, Jive will show a blank page with the heading "Stopped".  We either want to block now playing entry for empty playlist on Jive or do the changes suggested here.  I'd also recommend adding "empty" to the jive ui as well so that folks don't think something simply didn't show up on Jive ("this space intentionally left blank") 
Comment 3 Blackketter Dean 2007-12-27 13:53:37 UTC
I agree.  Pressing the Now Playing button should jump you to:

Now Playing
Nothing

and left should take you back to the home menu.  

KDF: If you want to look at this for 7.0, that's fine with me, otherwise please mark as Future and we'll look at this later.
Comment 4 KDF 2008-01-01 20:25:41 UTC
SqueezeCenter changes merged at change 15738.
Now playing on Jive, for empty playlist still needs work (shows last known item even after it's removed, so I guess it doesn't properly update on empty playlist)
Comment 5 KDF 2008-01-17 17:10:53 UTC
I'm basically done with server-side, and I believe Ben has been doing a lot of changes on the now playing/current playlist in jive.  I'm not sure what the reference design target is, but screen jumping seems to be in line "now playing" button pressing behaviour.

Ben can either close off, or merge with the other Now playing bug.
Comment 6 Ben Klaas 2008-01-17 17:45:39 UTC
Hmmm...interesting, first I've seen of this SC bug. I've been working fairly heavily in this UI area of Jive, and what I have arrived at is this:

NowPlayingApplet = Big Artwork "now playing" page, served by NowPlaying applet
CurrentPlaylist = Playlist page, served by SlimBrowser applet

when playlist is non-zero in size:
Home Menu: Now Playing <-> NowPlayingApplet <-> CurrentPlaylist

when playlist is empty:
Home Menu: Now Playing <-> CurrentPlaylist, with one single non-selectable "nothing" item in the menu

everything works as described there, except for the "nothing" item. That worked too, until Richard broke it... :)
Comment 7 KDF 2008-01-17 18:35:07 UTC
that's what I thought.  I was sure there was a "nothing", but wasn't seeing it now.  That's all that's left for this one really.

We did actually speak about this one last week sometime, I just didn't end up mentioning the bug number because you were already working on the very thing needed :)
Comment 8 Blackketter Dean 2008-01-21 09:57:51 UTC
This is now only Jive, right?
Comment 9 Ben Klaas 2008-01-21 10:44:50 UTC
yes, just Jive.

Changed summary to make more sense to the issue left to fix.
Comment 10 Ben Klaas 2008-01-21 13:38:04 UTC
fixed in SC 7.0 branch change 16542
fixed in jive r1544
Comment 11 Ben Klaas 2008-01-21 13:40:26 UTC
Created attachment 2696 [details]
screenshot of playlist window when playlist is empty
Comment 12 James Richardson 2008-05-15 13:00:12 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html