Bugzilla – Bug 6091
Albums/Artists can't be played from the favorites
Last modified: 2007-11-15 08:45:29 UTC
I've migrated this from a forum post because nobody has replied one way or another after a few days, and I still cannot seem to get the favourites to work... I'm not sure if I've broken something with my changes for bug#112, so maybe someone else can tell me... I've been using the svn versions for quite a while and can't seem to get favourites to work. Here's the sequence I'm using... 1/ Press browse on the remote. 2/ Locate the album I want - first find The Mission, select, choose The First Chapter. 3/ Press and hold Favourites until the item is added. 4/ Press Favourites to display the menu. 5/ See 'The First Chapter' listed. 6/ Press Play. 7/ Observe the squeezebox showing: Playlist empty: db:album.titlesearch=FIRST%20CHAPTER And then not doing anything. Notice that the URL is both incomplete (it doesn't include the album) and doesn't work - because it's not playing anything. 8/ Repeat this sequence with the artist, ie on The Mission add to the favourites, 9/ Press Favourites to go to the menu 10/ Press play over 'The Mission'. 11/ Squeezebox shows: Playlist emtpy: db:contributor.namesearch=MISSION 12/ Again repeat sequence, but now go to the first track on The First Chapter (Like a hurricane). 13/ Press and hold Favourites to add it. 14/ Press Favourites to go to the menu. 15/ Locate Like a hurricane. 16/ Press play. 17/ Be astounded that that actually plays :-) So... is this just me or is Favourites not working ? I've never really used it before and I don't know if I've broken it myself - are you meant to be able to favourite artist and albums in this way ? All tests done on svn 14429. Flagged as Major because a significant button on the remote control appears to not function correctly.
Justin - we've add some fixes to the Favorites late last week (change 14585). Could you please give it another try? I can't reproduce the behaviour you're describing.
Just updated to the latest svn 14670 and it's completely repeatable for me. I'm now going to remove my patch for bug #112 and see if it is repeatable with a bog-standard 14670.
Repeatable with an unmodified 14670 squeezecenter.
Repeated again with a few different options; what additional information would you like me to provide ? I can enable the debug, but I'm not sure exactly which debug is useful :-)
On the principle that it can't hurt, here's the log output from setting the Favorites debugging to 'Debug' and then doing steps 1 through 3 - these should be sufficient because the debug tells me that it's selecting by an album name, which is wrong... [19:18:45.1311] Slim::Plugin::Favorites::OpmlFavorites::add (151) url: db:album.titlesearch=FIRST%20CHAPTER title: The First Chapter type: parser: [19:18:45.1336] Slim::Plugin::Favorites::Opml::save (116) OPML saved to file tempfile: /music/sserver/Playlists/HFI4yooD3Y.opml [19:18:45.1342] Slim::Plugin::Favorites::Opml::save (125) Renamed /music/sserver/Playlists/HFI4yooD3Y.opml to /music/sserver/Playlists/favorites.opml [19:18:45.1314] Slim::Plugin::Favorites::OpmlFavorites::add (151) url: db:album.titlesearch=FIRST%20CHAPTER title: The First Chapter type: parser: [19:18:45.1338] Slim::Plugin::Favorites::Opml::save (116) OPML saved to file tempfile: /music/sserver/Playlists/HFI4yooD3Y.opml [19:18:45.1343] Slim::Plugin::Favorites::Opml::save (125) Renamed /music/sserver/Playlists/HFI4yooD3Y.opml to /music/sserver/Playlists/favorites.opml
I still can't reproduce. "2/ Locate the album I want - first find The Mission, select, choose The First Chapter." - does this mean you go the track "1st chapter" of the album "The Mission"? You want to add a track to the favorites? Can you reproduce this with any song? The debug flag would be "favorites"
Ah; it's possible I should have selected another artist and album combination as this was unclear. The artist is 'The Mission' The album is 'The First Chapter' Go to My Music. Select Artists. Select Genesis (the artist). Move to Lamb Lies Down On Broadway (the album. Press and hold Favourites over Lamb Lies Down. I want to add the /album/ to the favourites. This doesn't work; the URL that's added is a db: url which selects the album and... doesn't work when you try to play it. Similarly... Go to My Music. Select Artists. Move to Genesis (the artists). Press and hold Favourites over Lamb Lies Down.
(In reply to comment #7) > Similarly... > > Go to My Music. > Select Artists. > Move to Genesis (the artists). > Press and hold Favourites over Lamb Lies Down. I /meant/... Press and hold Favourites over Genesis. This is trying to make Genesis a Favourite, but again does not work properly. I'll repeat this with debug on the actual player when I get home after work.
Ah, at last... The Lamb, that did it. I think I missed one of your steps. Now I see what you mean. I've changed the summary accordingly. Also I doubt it's a major issue: it's rather a feature not implemented yet. Adding albums/artists to the favorites imho has never been implemented. I'll still investigate why it's not working.
Created attachment 2411 [details] check for playable objects which don't have a content_type set Could you please give this a try?
Andy - I've got a patch for this bug which seems to be working. But I'm not sure it's the right way to solve the issue. The root cause seems to be that albums/artists don't have a content_type defined. Thus they fail the test. But is adding them in condition the right solution?
Applying this patch to svn 14713 allows the albums favourited in this way to work. And allows the artists to be favourited as well. So I'm pretty happy with that. Sorry that my original report was not descriptive enough for you to reproduce initially. However, there's a separate and distinct bug in that although the favourite plays, it isn't being added properly. Should I create a separate bug for this ? The separate problem is that the album added is not unique. For example, if I go to Artists->Blondie and add 'Greatest Hits' to the favourites, the URL that's added is 'db:album.titlesearch=GREATEST%20HITS' which isn't accurate enough - and if I play it from the favourites menu, I get Aerosmith's Greatest Hits playing.
Change 14741 - we'll have to handle the "Greatest hits problem differently"