Bugzilla – Bug 6006
Favorites - can't fully rename 'By Genre' favorite
Last modified: 2014-10-16 22:42:50 UTC
Well, you can rename it, but it's not reflected in the breadcrumbs, remaining 'By Genre'.
this is an xmlbrowser issue. $feed->{'title'} for @crumb isn't updated when an item is changed.
Is this a problem with the Default skin only? I'm trying to understand the process to reproduce this - if you edit the title of a favorites folder, at that point you should not see that folder on the breakcrumb list? Is this occuring when you subsequently select it?
> Is this a problem with the Default skin only? No, all skins. > I'm trying to understand the process to reproduce this - if you edit the title > of a favorites folder, at that point you should not see that folder on the > breakcrumb list? Is this occuring when you subsequently select it? Yes. It appears correctly on the page, but not in the breadcrumb list. And it appears to only be a problem with the 'By Genre' favorite that was included/installed with 7.0. If I create a new folder and subsequently rename it, it appears correctly in the breadcrumbs.
What - "By Genre" favorite? I've not seen one or intended for there to be one... If you look at the favorites.opml file does it include this entry? Michael - is there something you have added in the install process creating favorites entries?
> What - "By Genre" favorite? I've not seen one or intended for there to be > one... I could be mistaken that it was added with the install. My SVN of 7.0 has been around for a while, so maybe I added it when playing with the Favorites interface at some point in the past. It's from Slim Picks > Internet Radio > By Genre. When I rename it to 'Slim Picks by Genre' I see the breadcrumb behavior described above. > If you look at the favorites.opml file does it include this entry? Yes, here's the entry: <outline URL="http://www.slimdevices.com/picks/split/By%20Genre.opml" text="Slim Picks by Genre" /> Could it be beacause it points to another .opml file?
That's a valid favorite and would be added when you click on the favorite icon in slimpicks by genre. (I suspect it was added by you doing that rather than the install.) The reason it does not change the name is that xmlbrowser uses the title from the referred to opml file for the breadcrumb rather than the text entry in the refering opml file. Given that you can't edit the slimpicks file itself you can't change the title for the page.. We probably need to to think what is the right thing to do here - at present it is operating as xmlbrowser has always done ie when it fetches a subfeed it is put into the data structure in place of the url and title - this results in what you are seeing.
yes, the slim picks entries must have come from the early days of the new opml favourites. One of the early examples was to load a copy of the Slim Picks opml file, so that's probably a hold over.
Fair enough. It's seems fairly minor, so I'm changing the severity. See if someone can come up with a better bug title for future reference.
Triode - is this the same as the second part of bug 6544?
I suggest this one is kept open as it remains, but there's a question of what the right thing to do here is. I believe 6544 should be closed as I think its fixed.
We planned to rework the favorites/presets/radio stations/podcasts etc. functionality.
The favorites redesign is not going to happen for 7.4/8.0
This is now working properly in both 7.8 and 7.9.