Bug 6005 - Default skin: Favorites breadcrumbs has extra link
: Default skin: Favorites breadcrumbs has extra link
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-02 14:44 UTC by Jim McAtee
Modified: 2008-12-18 11:12 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
pwd (7.34 KB, image/png)
2007-11-02 21:39 UTC, KDF
Details
screen capture (8.56 KB, image/pjpeg)
2007-11-02 21:56 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2007-11-02 14:44:06 UTC
Broswing Favorites > Some Favorite places an extra link in the breadcrumbs.

Hom > Extras > Favorites > By Genre

"Extras" isn't part of the hierarchy.  This appears to be only happening in the Default skin, as EN and Classic don't do this.
Comment 1 KDF 2007-11-02 16:19:29 UTC
it's an error while handling the 'homeCategory' variable, used only by the Default skin for it's "live" home page. Favourites uses the xmlbrowser.html template, which assumes that it's being used by a plugin if homeCategory is not defined.  The only way to not have the homeCategory link in the pwd_list is by leaving homeCategory undefined.  This is currently not possible for xmlbrowser.html
Comment 2 KDF 2007-11-02 21:06:26 UTC
fixed in change 14335
it's an odd fix ('' isn't the same as not existing) so please do verify and reopen if it isn't working for you.  It doesn't for me.
Comment 3 Jim McAtee 2007-11-02 21:27:09 UTC
No, it's still there for me, although there is one point at which it disappears:

1. Click a favorite (say 'By Genre').

  Home > Extras > Favorites > By Genre

2. Click 'Favorites' in the breadcrumbs.

  Home > Extra > Favorites

3. Click 'Favorites' again.

  Home > Favorites
Comment 4 KDF 2007-11-02 21:37:58 UTC
By Genre was my test.  clicked on it and it was gone.  check caches, etc, etc.
I'll let Michael test and report back. 

for me: all three of your steps show the right PWD.
Comment 5 KDF 2007-11-02 21:39:46 UTC
Created attachment 2342 [details]
pwd

sample screenshot, after clicking "By Genre"
Comment 6 Jim McAtee 2007-11-02 21:46:02 UTC
Cleared browser caches for sure.  Will clear SC cache and report back...
Comment 7 Jim McAtee 2007-11-02 21:56:29 UTC
Created attachment 2343 [details]
screen capture

No, I'm afraid that for some reason it's still there for me after clearing the SC cache.  In both FF and IE6.
Comment 8 Jim McAtee 2007-11-02 22:01:08 UTC
Hmmm, I just noticed... our screen caps have different titles shown in the dark gray area.  Mine was taken in FF 2.0.0.9 on Windows XP Pro.
Comment 9 KDF 2007-11-02 22:37:57 UTC
FF 2.0.0.9 as well

I have found something.  some favorites show the problem, my "By Genres" does not. Obviously needs a more, brute force solution. I'm almost nostalgic over the pain of dealing with js updated states.
Comment 10 KDF 2007-11-02 22:51:18 UTC
change 14339 goes all the way, relying on specific definition of homeCategory for it to be shown. home.html is doing this for each section, so it makes sense as long as new sections follow the same design.
Comment 11 Jim McAtee 2007-11-03 12:39:29 UTC
Looks good.
Comment 12 Chris Owens 2008-03-07 09:05:15 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.