Bugzilla – Bug 5914
Default Skin: Settings don't open in a tab
Last modified: 2008-12-18 11:12:53 UTC
Clicking the "Settings" link in Firefox (on Windows) opens the Settings page in a new browser window, despite the Firefox Tabs option of "New pages should be opened in a new tab" being set. It appears the third parameter being passed to window.open() is the culprit. I suppose that by telling FF that you want the new window to have some particular set of features causes it to automatically launch the page in a new window. In main.js, there's: window.open(webroot + 'settings/index.html?player=' + player, 'settings', 'dependent=yes,resizable=yes,scrollbars=yes'); Resizable and scrollbars should be on by default. Not sure how important it is to make the page dependent. This change allows the Settings page to open in a new tab: window.open(webroot + 'settings/index.html?player=' + player, 'settings');
seems reasonable. It would also be nice if the settings window size hint was not full screen.
The problem is I can't change the browser's behaviour: Opera would open a new tab, FF does not. I've googled a bit, found some discussion of the issue, but no reliable solution yet. The problem is opening a window using JS (to get rid of the toolbar etc.). A simple link with a target should work. But then marketing would cry... BTW: I had to add the scrollbars parameter because FF or Opera or Safari or IE wouldn't display it without.
Oh, one more idea: if opening a new tab should be default behaviour, I could decide dynamically what action to link to the button, based on the browser. I'll give this a try. Regarding full-screen: I can either _not_ set the size, leaving it to the browser to decide. Or define the size, which will provoke complaints by users. We've seen this with the wizard. And if you the new page in a new tab, then it will be whatever your browser was. Can't have tabs and different size at the same time.
I don't understand the "marketing" angle to using javascript to open a simple link. If it can be done in plain HTML, why not do it like that?
The idea was to have a new window _without_ the usual browser controls (adress field, back/fwd buttons etc.). That's often thought of as being more application like, more user friendly, whatever.
Change 14165 - don't use JS to open those windows.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.