Bugzilla – Bug 5812
Delete Favorite reports Insert Deleted
Last modified: 2011-11-06 23:23:05 UTC
If I delete a favorite, the web UI changes the deleted entry to say "Insert Deleted [<name>]". In the Fishbone skin, the other items in the favorites list move position (displayed below the buttons). The "Insert Deleted" entry is still displayed until the favorites screen is refreshed. Once I saw the deleted entry come back into the favorites list, but I have been unable to find a repeatable case for this.
"insert deleted" is a chance to undelete the item before it is removed for good. The control on the right in this case verifies the delete, clicking on the "insert deleted" re-enables the item in the favorites list (now at the end of the list). The items move up because too many users complained when the positions where left empty, despite the fact that this changes the number keys usered to access a given favourite.
What I meant by "other items in the favourites list move position" is that after deleting a favourite using the Fishbone skin, the other playlist items float way off the bottom of the list. I'll include a screenshot...
Created attachment 2273 [details] screenshot of fishbone skin after deleting a favourite You can see the first favourite in the list ("A Silver Mt Zion...") has moved down the screen, below the buttons. If I move the mouse over the item, it returns back to the correct position in the list of favourites.
If I delete a favourite (so it changes to "Insert Deleted", and then also delete another favourite, the first one is permanently deleted, and cannot be retrieved. Similarly, if a favourite is deleted, and the screen is refreshed or the user navigates away and back again, the item is permanently lost and cannot be retrieved. So I don't really see much point of the "insert deleted" option. When deleting a playlist, the user has to confirm the deletion. It would be good for both playlist and favourites to share a similar mechanism.
all of this is by design. "floating to the bottom" is what it does. There is no bug here. What is here is that yes, the "insert delete" is a touch ridiculous. It's not used anywhere else nor on any other UI for favorites, so it's inconsistent and confusing. cc'ing bdils as it may be something worth looking at while doing the UI review.
Did you see the screenshot? I can't believe this is by design. I also found that it goes wrong if you try to add a new favorite in the Fishbone skin within the Favorites WebUI page. Most of the existing entries move way down the screen, and move back to their correct place only when moving the mouse over the place where they should be. I'll upload another screenshot.
Created attachment 2294 [details] items move down the screen when adding or deleting entries.
Unassigned bugs cannot have a priority.