Bugzilla – Bug 5797
Cant edit local entries in playlist
Last modified: 2009-09-08 09:19:11 UTC
If I go to edit a playlist, I can't easily choose an existing entry to edit. I assume that clicking on a song name in the edit playlist screen should allow that entry to be amended (by clicking the add button). This is broken. The first song is selected by default. If I click up or down arrows on an entry will also select the entry that falls on the row that has been clicked on, after it has moved position. I have checked this in both Fishbone and Default skins.
The ability for editting individual items is currently reserved for remote urls. loading an existing playlist, adding tracks can be done via current playlist. However, not impossible to remove the isRemoteURL check for the edits. I no longer recall the exact reason for it, but it's not technically a "bug". I'll leave open as enhancement and maybe a review by QA can rethink what is desired.
I would still consider there a bug to be fixed one way or another, even if we deem that normal song playlist entries are not editable, because currently they are (indirectly)! The first playlist entry is automatically selected (name and url values are displayed in the text entry boxes). Any playlist entry can be indirectly selected by pressing the move up/down buttons, so if users are only meant to be able to edit remote urls, this is not currently prevented.
Dean notes this screen is confusing, and should work like the Favorites edit screen.
Assigned to Brian for some "love" (to quote Dean)
I'm a little torn on how to deal with this issue because the user would expect to be able to modify a playlist on the left the same way you can on the right. However this is the only time where you don't have to be in the current playlist to edit right? I'm a little worried about breaking that model, but I think for now we should have the edit playlist look and act identical to the currently playlist panel. This includes allowing the edit panel to have artwork and drag/drop capabilities. The other issue is that the current playlist has play and remove buttons, while edit has play and add. What would everyone think of having add and remove for the edit playlist panel? I can't imagine a user is going to be editing a playlist and need to play a song right then and there. Otherwise we can have all three buttons.
A handy trick, Brian, is to add dean's email address to the 'Add CC' box in the upper right corner so he will be copied in email on your comments :)
I've started refactoring the playlist editing. The aim is to have it very similar to the favorites handling. In a first step (change 15664) I've removed the need to go to a separate page for editing. The list you get when browsing playlists should be editable directly (if available: iTunes playlists can't be edited). D'n'd does work in Default. TBD: - restore sorting d'n'd for Classic/Fishbone etc. - edit items
This should be fixed in some change from before christmas... Feel free to re-open if needed.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.