Bug 5743 - Setting default webproxy using environment on Unix, registry on Windows platforms
: Setting default webproxy using environment on Unix, registry on Windows platf...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Platform Support
: 7.0
: PC SuSE Linux
: P2 enhancement (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-09 14:02 UTC by Nicolas JUSTIN
Modified: 2008-12-15 13:08 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Proposed patch (951 bytes, patch)
2007-10-09 14:03 UTC, Nicolas JUSTIN
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas JUSTIN 2007-10-09 14:02:26 UTC
On Unix platform the proxy configuration could done system wide using the following environment variables:
 - http_proxy
 - http_proxy_port (optionnal)

The proposed patch add a defaultWebProxy handler in the Prefs system to use those variables.
Comment 1 Nicolas JUSTIN 2007-10-09 14:03:15 UTC
Created attachment 2243 [details]
Proposed patch
Comment 2 Chris Owens 2007-11-05 10:21:07 UTC
Not going to be added for the 7.0 release, but we will review it for 7.1
Comment 3 Michael Herger 2007-11-13 08:35:10 UTC
We should read the registry at HKEY_LOCAL_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyEnable et al. on Windows systems. Our solution to detect whether the user needs a proxy server or not is too simplistic and fails more often than it helps (see eg. bug 6120).

Chris - I think we should consider this for 7.0
Comment 4 Michael Herger 2007-11-14 05:04:22 UTC
Change 14688 - could you please test whether this is working for you?
Comment 5 Nicolas JUSTIN 2007-11-16 02:22:54 UTC
It works for me in the following cases with my OpenSUSE 10.3:
 - http_proxy with "http://" prefix
 - http_proxy without "http://" prefix
 - using http_proxy_port
 - not using http_proxy_port
 - only removing the webproxy entry in the server.prefs file
 - starting without any server.prefs

Thanks !
Comment 6 Michael Herger 2007-11-16 02:29:16 UTC
Thanks for the feedback!
Comment 7 James Richardson 2008-12-15 13:08:01 UTC
This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.