Bugzilla – Bug 5740
Switching language doesn't correctly update the playlist
Last modified: 2008-12-18 11:12:53 UTC
On SqueezeCenter 7.0 build 13563, I used the settings page to switch from English to Hebrew and then back to English. Upon refreshing the browser window, I noticed that the description of the currently playing track on the Playlist still had Hebrew characters. There are other issues with Hebrew, but I wanted to point out only this one for now. Screenshot enclosed.
Created attachment 2240 [details] Screenshot of english to hebrew to english
seems ok here, svn 13689. could be playlist update issues which have changed more recently.
Language changes as well as skin changes currently need a full page reload to take effect. This is even more important now as many parts of the skin are only loaded at startup.
QA to try to reproduce
Easily reproduced with SC 7 14368. From settings select Hebrew and refresh, then go back to settings, English and refresh, playlist shows some Hebrew styling and fonts.
this is probably the html caching used for the playlist. if nothing in the playlist changes, the server stores the render. one thing to try would be to add $client->currentPlaylistModified(1); as part of the code that forces Classic skin when the language is HE. Index: server/Slim/Web/Settings/Server/Basic.pm =================================================================== --- server/Slim/Web/Settings/Server/Basic.pm (revision 14400) +++ server/Slim/Web/Settings/Server/Basic.pm (working copy) @@ -77,6 +77,7 @@ # use Classic instead of Default skin if the server's language is set to Hebrew if ($paramRef->{'saveSettings'} && $paramRef->{'language'} eq 'HE' && preferences('server')->get('skin') eq 'Default') { preferences('server')->set('skin', 'Classic'); + $client->currentPlaylistModified(1); $paramRef->{'warning'} .= Slim::Utils::Strings::string("HIT_RELOAD"); }
change 14939 - needed to add two more lines to get it working Please note: this issue wasn't limited to HE at all. This needs to be done after _any_ change of language.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.