Bug 5713 - Problems with Advanced Search on Year field
: Problems with Advanced Search on Year field
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: PC Windows XP
: P2 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-07 15:45 UTC by Philip Meyer
Modified: 2009-07-31 10:14 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
exclude zero value years (621 bytes, patch)
2007-11-08 07:03 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2007-10-07 15:45:50 UTC
I tried to find songs that had a year less than 1960.  This took a long time to complete.

I then realised that I had an awful lot of results (I wasn't expecting any).  I believe that all tracks with no year tag were returned; no year must be represented by a small scalar value, so the query goes wrong.
Comment 1 KDF 2007-10-07 17:38:28 UTC
Does your browse by year show any odd values?
Comment 2 Michael Herger 2007-11-08 07:03:04 UTC
Created attachment 2386 [details]
exclude zero value years

Should we just ignore albums with no year set? This will very likely cause complaints by folks who want to use the search to find badly tagged albums.

Phil, do you have many zero value years in your collection?
Comment 3 Michael Herger 2007-11-08 07:41:46 UTC
Change 14509 - exclude 0 from "year < X" search, but allow as "year = 0" criteria
Comment 4 Philip Meyer 2007-11-09 01:52:00 UTC
I can confirm that is working.

The best UI solution would be to have "Is Blank", rather than for users to know that 0 means no year.  Otherwise a link to some advanced search help page may be a good idea.

"Is Blank" would be really useful on most search fields, as a way for user to find untagged music.

Also useful would be a Between filter option (eg. "Year between n and m").

Should I transfer this to an enhancement request, as this bug report could be considered fixed?
Comment 5 Michael Herger 2007-11-09 02:26:02 UTC
> The best UI solution would be to have "Is Blank", rather than for users to know
> that 0 means no year.  Otherwise a link to some advanced search help page may
> be a good idea.

Then there would be no way to search without the year.

> Also useful would be a Between filter option (eg. "Year between n and m").
> 
> Should I transfer this to an enhancement request, as this bug report could be
> considered fixed?

Yes, please do so.
Comment 6 Ross Levine 2008-07-24 15:44:49 UTC
Verified to be fixed in 22048. Saw this issue in 6.5.4. 
Comment 7 Chris Owens 2008-07-30 15:30:00 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 8 James Richardson 2008-12-15 12:32:08 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 9 Chris Owens 2009-07-31 10:14:56 UTC
Reduce number of active targets for SC