Bug 5688 - Rescan progress info on SB display is incorrect
: Rescan progress info on SB display is incorrect
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Display
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-06 16:35 UTC by Philip Meyer
Modified: 2008-12-18 11:12 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2007-10-06 16:35:45 UTC
i started a rescan of my music library from my SB. It was nice to see progress info is now displayed.

However, for each stage of the process, the progress step total is displayed incorrectly. It says "(1 / 1)" ... "(8 / 8)". i.e. first and second numbers are always the same.

Also, initially there is a long pause before the first progress update. i suggest a "please wait for progress" message whilst the initial info is calculated.  i thought something was broken, so i navigated back one level to the rescan plugin. it appears that a user could invoke the rescan again from the menus whilst the first scan is still running.

there is also an empty menu on page 5 of 5. you cant get back to the progress unless you go back another level and go back into the plugin again.

the initial progress for each step displays as either (/) or (0/), which is a little bit confusing or at least inconsistent. i suggest not displaying the bracketed bit until the info is known.
Comment 1 KDF 2007-10-06 19:22:41 UTC
1/1 is correct as each progress section is built up when required.  It is not known that at the start, there will be 8 stages.  some will have less.  The display updates to the last item in the list, hence the numbers represent "last"/"total".

the missing 5th stage is probably a missing string.

Comment 2 KDF 2007-10-06 19:39:13 UTC
All lines seem to have strings, so I wonder if you have some sort of plugin happening there.  However, i also have 9 items:

1. Folder
2. MusicIP
3. Playlist Scan
4. Merge Various Artists
5. Arwork
6. Database Cleanup #1
7. Database Cleanup #2
8. Database Optimise
9. Rescan Complete

where is the blank fitting in?
Comment 3 KDF 2007-10-06 21:40:12 UTC
some fixed in at change 13617
found the missing string and adjusted the text used at each stage, as well as when the x/y counts are added.

Still to do:

ideally we'd use block mode at the end of setProgressMode so that the display says...
Please Wait...
Rescanning Music Library

with the block animation on the right, until the first importer is started.  I've added the unblock in progressHeader where I think it should be, but I can't seem to set up block mode without getting modeParam errors in progressUpdate.

Triode, are we unable to carry modeParams through block mode or am I missing a cleaner way to create the screen while we wait.?

Comment 4 Adrian Smith 2007-10-07 10:33:58 UTC
Kevin - please try change 13630.
Comment 5 KDF 2007-10-07 12:02:01 UTC
thanks, Triode.  that's exactly what I was looking for (someday, I'll even understand what you did ;)
Marking as fixed as this is now where I intended it to be.  Please reopen if there are any issues.
Comment 6 Chris Owens 2008-03-07 09:04:58 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.