Bug 5684 – Change text in Nokia770 skin for removelink

Bug 5684 - Change text in Nokia770 skin for removelink

Summary:

Change text in Nokia770 skin for removelink

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Skins
Version:	7.0
Platform:	PC Other

Importance:	P2 trivial (vote)
Target Milestone:	---
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-10-05 20:06 UTC by Erland Isaksson
Modified:	2007-10-06 13:43 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Patch that implements the change (382 bytes, patch) 2007-10-05 20:09 UTC, Erland Isaksson	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Erland Isaksson 2007-10-05 20:06:15 UTC

I would suggest that the removelink wrapper defined in HTML/Nokia770/cmdwrappers is changed so it shows the text "Delete" instead of "Delete from playlist". This is how it is defined for the other skins.

The reason for this change is to make the "removelink" wrapper more useful, it can currently only be used for delete buttons in playlists, but if this would be changed plugins would be able to use the removelink wrapper for deleting other kinds of items.

Comment 1 Erland Isaksson 2007-10-05 20:09:22 UTC

Created attachment 2220 [details]
Patch that implements the change

Comment 2 KDF 2007-10-05 20:45:52 UTC

what do you think, ben?  Some of these are very similar to the EN blocks.  it might even make sense to try to convert this to cmdwrappers_Nokia770 and get rid of the duplicated blocks.  I can probably get that started if you are busy.

Comment 3 Ben Klaas 2007-10-06 13:43:37 UTC

Sure. I wasn't actually aware of the cmdwrappers_skinName convention. The idea is that cmdwrappers is base, and cmdwrappers_skinName overwrites cmdwrappers functions?

Sounds good to me. I'm always in favor of a reduction in redundant code. Feel free to get it started if you like KDF, otherwise just let me know and I'll do it.

In the meantime, Erland I checked in change #13616 for that string.