Bugzilla – Bug 5678
Default skin - inconsistent drag & drop indicator behavior
Last modified: 2007-12-28 07:09:57 UTC
I like this recent twist on dragging in the playlist, but it's a little inconsistent, making it feel sloppy. There's also a small bug in that occasionally the indicator won't go past the bottom item in the playlist, making it impossible to drag the item to the end of the list. One of the inconsistencies are that the relative position of the indicator to the dragged item seems to change. Occasionally the indicator is behind the dragged item, but often it's well below or well above the highlighted area. I think it would feel best if the middles (vertically) of both the dragged item and the existing items below were used to determine the indicator placement. Another inconsistency is that the indicator disappears when you drag an item over its original playlist position. I think it would just feel more solid if the indicator were always shown. Of course dropping the item when the indicator is either above or below the original should leave the item in the same position.
> There's also a small bug in that occasionally the indicator won't go past the > bottom item in the playlist, making it impossible to drag the item to the end > of the list. Can't reproduce this. Which browser? > One of the inconsistencies are that the relative position of the indicator to > the dragged item seems to change. It does indeed: it always shows where the song will be dropped. When dragging down, inserting the mark _above_ the target would be confusing. The current behaviour is Dean's call. You'll have to convince him of a better solution ;-).
> It does indeed: it always shows where the song will be dropped. When dragging > down, inserting the mark _above_ the target would be confusing. The current > behaviour is Dean's call. You'll have to convince him of a better solution ;-). That doesn't really make any sense. The indicator points _between_ items, which is where the dragged item will be _inserted_. When dragging items, a user doesn't think "I'm moving this to position number 3", instead he thinks "I'm moving this to between these two songs". Implemented like this, the indicator would never be above or below the dragged item. When you pass the mid-mark of the item behind the dragged item, the indicator would move above/below that item, but it would always be behind the transparent dragged item. It just feels squirrelly the way it is now.
Dean to review this behavior.
I'm expecting a line to appear between the songs where the dragged item will appear. I'm not seeing anything at this point... Firefox 2.0.0.9 and Safari 3.0.0.4 on Mac.
The style was white on white for the indicator... Change 14980 should fix this.
Looks good to me. Please reopen if you are still having problems.