Bugzilla – Bug 5669
album artwork handling
Last modified: 2008-12-18 11:12:53 UTC
I have an album cover that appears corrupted when displayed as a hover over the currently playing track. It looks okay in the smaller thumbnail, and also when I click to browse the full image, but there are spurious dots visible in the hover-over display. See attachment.
Created attachment 2214 [details] corrupt album artwork
probably transparency masks.
(Micheal, I'm adding you to the cc: here since I keep bouncing around the cover image URLs in Default. Sorry about that--there's just not a clear path to making this work yet. It will stabilize with acceptable transparency for both IE and non-IE after the items below are fixed.) Yes, it's transparency masks. With GIF you have to set a color for transparency, and I chose 0xaaaaaa, more or less out of a hat. The cover art that opened this bug has a lot of 0xaaaaaa pixels. In a perfect, non-IE world, we'd just be converting to PNG transparency. Since we don't live in that world, I'm moving the large pop-up to jpg and leaving the smaller as GIF, which will eliminate this issue Note: this will create a white border for any image that needs padding in the big image, and until GD gets upgraded will not correctly create transparent thumbnails in GIF format. I think this bug should stay open as there are a few things that can make this work better-- 1. make a TT varbind that allows skin to know what browser is being used [% IF clientBrowser == 'IE' %]gif[% ELSE %]png[% END %] 2. upgrade SC's GD from 2.30 to 2.35 to eliminate GIF transparency bug in 2.30 3. change 0xaaaaaa to the pixel color that will cause the least visible artifacts. White is definitely not it. 0xaaaaaa appears to also not be it.
isn't it possible to have the popup just follow the size of the artwork, and let images fit their aspect ratio based on a set width only.
nice recommendation KDF. r13561 has that fix. Works like a charm for non-standard aspect ratio art.
remember, its "change 13561" in order to have a link to the svn record. going to reassign to you, ben, as this is your work in progress. rewording summary to fit the work and we can close when it's up to snuff.
Is transparency expected to be working now? I'm a bit confused as coverart in Default still is rather ugly with those borders...
It should actually look worse to you right now, but we're going down the correct path for fixing. first problem: the default place-holder, that ugly question mark, is a noisy image that looks awful with GIF transparency + resizing. We are waiting on a clean replacement for that image from Noah. Windows GD looks like it was just built by Andy (thanks), and that's important, as GIF transparency was broken in the version we are using currently. GD should be updated on all platforms now. I'm also going to try Andy's IE PNG transparency fix. If that gives us enough reliability with PNG transparency to use that as a default, we can go with that. One big question mark left to figure out is what to do with users that don't have GD on their system. If we're still making GD optional, there needs to be some testing in that area (I currently don't have a GD-less SC installed anywhere)
change 13678 should fix all of the outstanding issues here. Still need an updated generic cover art image, but otherwise this is now fixed in all browsers. GD is effectively required now browserType is a skin variable gif is used for IE, png for anything else default background color is now transparent moving to RESOLVED
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.