Bugzilla – Bug 5663
cmdlink behaves different in Nokia770 skin
Last modified: 2008-12-18 11:12:53 UTC
The "cmdlink" wrapper behaves differently in the Nokia770 skin compared to the other skins. The result is that you can't use the cmdlink wrapper in a HTML template to make the HTML template independent on skins. For example this causes problem with the mixer buttons, where it would be possible to do: [% WRAPPER cmdlink cmdimage='b_mmmix' cmdtitle='MUSICMAGIC_MIX' %]....[% END %] But to make this work in the Nokia770 skin you will need a specific HTML template for Nokia770 that instead contains: [% WRAPPER cmdlink cmdimage='b_mmmix.gif' cmdtitle='MUSICMAGIC_MIX' %]....[% END %] The difference is that most skins seems to add .gif to the cmdimage parameter besides the Nokia770 which doesn't add .gif and instead requires the user to specify .gif in the parameter value. I've only verified the problem with my own plugins, but I strongly suspect that the MusicMagic plugin will display its mixer buttons as text instead of an image in the Nokia skin as the cmdlink wrapper works now. The cmdlink wrapper is defined in: server/HTML/Nokia770/cmdwrappers
The intent there was to make it simple for images, but the new default is tending toward use of .png types. This may be something that is expected to increase so it may be wiser to rework cmdlink to require the extension as well. Michael, so far Default uses gifs for cmd links, but are you preferring .png; are you expecting to move in that direction? I can easily make a patch either way, just say the word.
I'm utterly confused, really: the endings have changed three times within a week. Didn't you (kdf) some changes which resultet in using .jpg? I then changed to .png. And Ben moved today/yesterday to .gif... I decided not to touch this any more as long as Ben is working on getting transparent GIFs fixed. I would love to use PNGs, but there's one reason not to do so... Default uses tons of graphics, and Scott has to render them in whatever color will be chosen. Though I would have ignored the IE6 uers in the case of artwork. It probably makes sense to leave the choice to the skins, as different skins are optimized for different targets. Handheld's target Pocket IE very likely doesn't support .pnt neither.
Michael, this isn't cover art. This is the images for add, play, mix, delete etc. I'll do a patch to require skins to supply full filename :)
fixed in trunk at change 13553. please reopen if there are issues.
missed a conversion in Default skin, fixed at change 13558
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.