Bugzilla – Bug 5661
Favorites: need to be able to add favorites with Jive
Last modified: 2008-05-15 12:59:37 UTC
I propose that we add an item: Add To Favorites as the last list item on the following screens: Song or Station Info Album Artist Genre With a confirmation screen following: ----------------- Add To Favorites Cancel Add <itemname> to Favorites -----------------
this needs to be in 7.0 setting priority to P3 for my own ordering of 7.0 bugs
edit summary for list organization. favorites support is #2 in my queue now, after playlist screen update work.
urgh...I have an ADD_TO_FAVORITES string, but not an ADD_X_TO_FAVORITES string, which is what I need for Add <itemname> to Favorites in the window... what should I do for 7.0?
How about just "Add <itemname>"? That's probably better anywy.
Okay, I changed it to this text => Slim::Utils::Strings::string('ADD') . ' ' . $title, which I think is maybe not a good way to use string tokens, given that there is an assumption that the word for 'add' will be first in all langs. good enough for 7.0 IMO
fixed in SC change 16768 Description: add string for JIVE_ADD_X_TO_FAVORITES, not used until translation is provided removed the insanity of trying to make sure $start/$end/$count/$cnt were all incrementing correctly make _jiveAddToFavorites and _playAll pull in $count and $chunkCount and increment as needed send $count to $request response only after the list has been put together and we know what the $count really is jive favorites support: put an 'add to favorites' link at the bottom of the following jive screens: album track listing song info internet stream info genre listing artist listing year listing format URL correctly use titlesearch for album favorite url, which kind of stinks but what can you do. can't use album id because ids are lost on rescan and then your favorites point to the wrong albums try adding a favorite for an album called 'greatest hits'...not recommended
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html