Bug 5660 – Pause button on Jive should start playback if player is stopped

Bug 5660 - Pause button on Jive should start playback if player is stopped

Summary:

Pause button on Jive should start playback if player is stopped

Status:	RESOLVED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	UI
Version:	unspecified
Platform:	Macintosh Other

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Felix Mueller

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-10-03 17:26 UTC by Blackketter Dean
Modified:	2007-10-30 10:27 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2007-10-03 17:26:12 UTC

Felix has a patch for this for the existing remote, but this doesn't work on Jive.

Comment 1 KDF 2007-10-03 17:48:43 UTC

something like this should be enough:
Index: C:/slim/src/pkg/jive/share/jive/slim/Player.lua
===================================================================
--- C:/slim/src/pkg/jive/share/jive/slim/Player.lua	(revision 633)
+++ C:/slim/src/pkg/jive/share/jive/slim/Player.lua	(working copy)
@@ -484,9 +484,7 @@
 	local paused = self.state["mode"]
 	log:debug("Player:togglePause(", paused, ")")
 
-	if paused == 'stop' then
-		return
-	elseif paused == 'pause' then
+	if paused == 'stop' or paused == 'pause' then
 		self:call({'pause', '0'})
 		self.state["mode"] = 'play'
 	elseif paused == 'play' then

Comment 2 Blackketter Dean 2007-10-03 19:48:18 UTC

Looks good to me, but I haven't tested.

Comment 3 KDF 2007-10-03 20:02:47 UTC

It works as you have described. committed at r637. I'll leave open for when the SC patch is in to make the remote control match up.

Comment 4 Chris Owens 2007-10-30 10:27:52 UTC

Richard considers this fixed.  Please reopen if there continues to be a problem.