Bug 5641 - Default Skin, dual scrollbar on playlist track listing.
: Default Skin, dual scrollbar on playlist track listing.
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: Macintosh MacOS X 10.4
: P2 normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-01 18:48 UTC by KDF
Modified: 2007-10-02 00:30 UTC (History)
0 users

See Also:
Category: ---


Attachments
screenshot (28.85 KB, image/png)
2007-10-01 18:48 UTC, KDF
Details
simplest patch (520 bytes, patch)
2007-10-01 19:49 UTC, KDF
Details | Diff
full patch (2.61 KB, patch)
2007-10-01 19:54 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2007-10-01 18:48:17 UTC
Browse Playlist
Select Playlist
note: playlist track listing has scrollbar but also the browse pane.

OSX 10.4.9, firefox 2.0.0.7, svn 13458
Comment 1 KDF 2007-10-01 18:48:45 UTC
Created attachment 2201 [details]
screenshot
Comment 2 KDF 2007-10-01 19:49:39 UTC
Created attachment 2202 [details]
simplest patch

simplest case would be to add the dontscroll param to the EN template.  no other skin uses it, but could if they wanted so it's safe there.

full patch, would be a copy of browsedb_playlist.html in Default with the Default pagebar block from browsedb.html.
Comment 3 KDF 2007-10-01 19:54:21 UTC
Created attachment 2203 [details]
full patch

this is the complete template that fixes the problem and should be in line with Default code style.
Comment 4 Michael Herger 2007-10-02 00:20:22 UTC
I'd go for the simple patch. That's exactly the use case I introduced the dontscroll parameter for. 

I didn't compare the full patch agains the EN playlist template. But as you can imagine I don't want to copy files around if there's a simpler solution...
Comment 5 Michael Herger 2007-10-02 00:30:56 UTC
Change 13462 - feel free to reopen, if you prefer the full patch.