Bug 5636 - Long tag display problem
: Long tag display problem
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: P5 minor (vote)
: 7.0.1
Assigned To: Ben Klaas
:
Depends on:
Blocks: 6785
  Show dependency treegraph
 
Reported: 2007-10-01 08:05 UTC by Craig Garnett
Modified: 2008-05-06 12:05 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Garnett 2007-10-01 08:05:00 UTC
If you go into a songs info and view the tags then scroll down, If there is a lyric tag the screen overwrites itself rather than giving scrollbars.

I've posted some screenshots here
http://forums.slimdevices.com/showpost.php?p=231648&postcount=17

Craig
Comment 1 Richard Titmuss 2007-10-05 14:46:44 UTC
Cool screenshot! That's going to be a problem to fix. Hmm.
Comment 2 Richard Titmuss 2008-01-11 06:09:25 UTC
Ben I wonder if this needs to be fixed SC side, the comment field should really open a new window using a text area.
Comment 3 Ben Klaas 2008-01-11 07:24:52 UTC
this is low priority for 7.0 release
Comment 4 Blackketter Dean 2008-01-18 10:25:06 UTC
For 7.0, it looks like we need to disable comments on Jive.  Then for 7.0.1, let's add in a descendent screen that lets you scroll through the comment.
Comment 5 Ben Klaas 2008-01-23 14:22:22 UTC
*** Bug 6731 has been marked as a duplicate of this bug. ***
Comment 6 KDF 2008-01-24 11:39:07 UTC
So, I've discovered that comments are currently suppressed even if requested in the query.  From the look of the code, however, it looks accidental so I guess this not is still useful.

For suppressing comment, why are we checking $val == 0 again?  Is this to suppress a numerical 0 in the comments, or simply suppress an empty comment?

Comment 7 Ben Klaas 2008-01-24 12:38:28 UTC
that's in there to suppress empty tags, which for one reason or another come in as numerical 0's
Comment 8 KDF 2008-01-24 13:17:42 UTC
heh, this comment seems to  be == 0 too:

"Although Alice in Chains singer Layne Staley dropped off the radar following 1995's Alice in Chains, it's amazing how good he sounds on 1998's \"Get Born Again,\" the one new track on this 15-song best-of outing. Sounding like a Dirt-era offering, the band's trademark dirgeful sound and melodic, layered, and haunting vocals shine on this strong Staley-Cantrell composition. And there's other interesting material that makes Nothing Safe a safe bet for fans. A demo of \"We Die Young\" is faster and more metal than the version on 1990's Facelift, while a live "Rooster,\" lilting \"Got Me Wrong\" (from Unplugged) and \"What Hell Have I\" from the Last Action Hero soundtrack are all eminently listenable. --Katherine Turman"
Comment 9 Blackketter Dean 2008-01-26 17:21:04 UTC
Are comments suppressed in 7.0 now?  If so, this should go to 7.0.1 where we'll turn comments back on.
Comment 10 KDF 2008-01-26 17:33:58 UTC
comments are left out of the song info query currently. so we push to 7.0.1
Comment 11 Ben Klaas 2008-01-29 20:30:04 UTC
Fixed in SC 16947. Enjoy...
Comment 12 Simon Turner 2008-01-29 23:12:41 UTC
Ben, you are a hero! I'm so gratefukl you fixed this before full release of 7.00.
BTW. It's War and Peace, not Moby Dick.
Comment 13 James Richardson 2008-05-06 11:30:44 UTC
(In reply to comment #12)
> Ben, you are a hero! I'm so gratefukl you fixed this before full release of
> 7.00.
> BTW. It's War and Peace, not Moby Dick.
> 

Marking bug as Closed, please reopen with added details if anyone sees this again.
Comment 14 Craig Garnett 2008-05-06 12:05:33 UTC
I originaly opened this bug refering to problems displaying lyrics on SBC, I've just tried to prove it fixed and can't find an option to display lyrics anymore even though they are there in the web UI!!

Craig