Bug 563 - unpausing from web interface causes box to play even if it's off
: unpausing from web interface causes box to play even if it's off
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: All All
: P3 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-20 10:30 UTC by Vidur Apparao
Modified: 2008-12-18 11:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vidur Apparao 2004-09-20 10:30:41 UTC
Pause player (from web interface or remote)
Power off player (from web interface or remote)
Hit play on web interface

Player starts playing, even though it's still off.
Comment 1 KDF 2004-09-20 11:37:32 UTC
changing Source.pm line 312 from:
if ($newmode eq "play") {

to:
if ($newmode eq "play" || $newmode eq "resume") {

should take care of it.  when the player is off, I believe it goes into playmose
pause.  A recent change added playmode resume, which is the state created when
the desired newmode is "play" from an oldmode of "pause"
Comment 2 KDF 2004-09-20 18:53:35 UTC
the diff for this fix:
Index: Slim/Player/Source.pm
===================================================================
RCS file: /home/cvs/cvsroot/slim/server/Slim/Player/Source.pm,v
retrieving revision 1.111
diff -u -p -B -r1.111 Source.pm
--- Slim/Player/Source.pm	16 Sep 2004 15:34:17 -0000	1.111
+++ Slim/Player/Source.pm	21 Sep 2004 01:09:23 -0000
@@ -309,7 +309,7 @@ sub playmode {
 	}
 	
 	# if we're playing, then open the new song the master.		
-	if ($newmode eq "play") {
+	if ($newmode eq "play" || $newmode eq "resume") {
 
 		# if the player is off, we automatically power on when we start to play
 		if (!$client->power()) {
Comment 3 KDF 2004-09-21 12:46:17 UTC
hrm...should this one be patched into the release retroactively?
Comment 4 KDF 2004-09-21 19:52:59 UTC
tested and committed to cvs sept 21, 2004
Comment 5 Rod Savard 2004-09-29 20:07:10 UTC
*** Bug 594 has been marked as a duplicate of this bug. ***
Comment 6 Chris Owens 2006-06-16 14:40:35 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.
Comment 7 Chris Owens 2008-12-18 11:54:08 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.