Bugzilla – Bug 5622
Delete from playlist not working in Random
Last modified: 2008-12-18 11:12:53 UTC
SqueezeCenter Version: 7.0 - 13344 - Windows 2000 - EN - cp1252 (9/29) Firefox 2.0.0.1, Opera 9.20 In the default skin trying to delete upcoming tracks in a random mode playlist doesn't work (previously played can be deleted). Noted that refreshing the browser carries out a stored button press.
Delete does appear to work, but it currently does not trigger a refresh of the playlist section. Which button command was being repeated? I ran a random mix and refreshed firefox with no noticeable effect on the initial random mix. Safari has a known problem where it will repeat POSTS and url queries for each frame in the browser. Are you see this same behaviour with firefix? or just opera?
this is a tricky one. The random mix adds a new track at the end if you delete a track, so the test used in default skin won't work (it matches the new track count with old track count). In Fishbone skin, when I experimented with this kind of playlist loading, I had to compare each track id, but the Default skin is optimised to avoid loading all of that info. It is also not valid to simply check the "is playlist changed" flag, as SC currently considers a change of current song as a playlist change. i did have a patch that got rid of the playlist change for a simple move to the next song, but that does require much more testing with all skins. At this point, Id suggest it may not be something we want to commit to for 7.0. Also, given that cometd is in use, it may be a post 7.0 thing to start using that for playlist updates. for now, it might be good enough to create a special case that puts up a flag for the json response saying that random mix is active, or force a reload from the playerControl function when the command is 'delete'
(In reply to comment #1) > Which button command was being repeated? Sorry, I meant if I click delete there is no response, but when I refresh the browser the track is deleted. If I try to delete more than one and then refresh it still seems only one is deleted. >Are you see this same behaviour with firefix? or just opera? I tested in both and it seemed to be doing the same thing.
Kevin already found the cause of this issue: the playlist is only updated when it changes. But the current method used doesn't recognize the deletion as a change.
Change 13428 - monitor the playlist timestamp to trigger updates when existing checks would fail
works for me. marking as fixed since we have a change number for the record. Please reopen if there are any issues.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.