Bug 5617 - Extras settings links go to Player Settings pages
: Extras settings links go to Player Settings pages
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugins
: 7.0
: All All
: P2 normal (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-29 12:39 UTC by KDF
Modified: 2007-09-29 13:14 UTC (History)
0 users

See Also:
Category: ---


Attachments
add needsClient param (3.31 KB, patch)
2007-09-29 13:03 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2007-09-29 12:39:46 UTC
Go into Server Settings-> Extras
Click on any of the plugins settings link
note that the resulting page will say "Player Settings" at the top and list only player plugins in the pulldown.

this is due to the following url in the plugins.html settings page:

<input type="button" value="[% 'SETTINGS' | string %]" onClick="location.href='[% webroot %][% settings %][% IF player %]?player=[% playerURI %]&amp;playerid=[% playerURI %][% END %]'">

the playerid param should only be there for player settings, so we'll either have to provide the needsClient param to teh plugins.html template or we'll have to do a different king of check on the settings.html templates in order to make sure we have either SErver or Player settings options in the header.
Comment 1 KDF 2007-09-29 13:03:04 UTC
Created attachment 2193 [details]
add needsClient param

this allows the setting subclass to direct the settings templates rather than depending on a passed url param entirely. player settings pages will therefore automatically call a player setting styled page when they need one and if a playerid has been properly provided for player settings.
Comment 2 KDF 2007-09-29 13:14:49 UTC
in trunk at change 13371