Bugzilla – Bug 5614
Random mix buttons don't work in default skin
Last modified: 2008-12-18 11:12:53 UTC
SqueezeCenter Version: 7.0 - 13344 - Windows 2000 - EN - cp1252 Seen in Firefox 2.0.0.1 and Opera 9.20 The button seems stuck on Random Songs. When hovering Random Artists, Albums, or Years, the cursor indicates a link that is not clickable. Behavior not seen in Fishbone skin.
Interesting. The hover highlight is indeed stuck. This is relatively new, as it was working only a few days ago.
fixed in trunk as of change 13392. Not sure if changelog is required for this one so leaving open for comment.
Kevin - I'll probably end up adding some JS to make sure all those elements have a unique ID (Ext.id()). The reason it now failed is due to my optimizing the highlighting: before I added the event handler when the page was loaded, now it's created in TT (onmouseover=Utils.highlight()). But this doesn't make sure anymore there's a unique ID, which we now have to take care of.
Random mix id's are unique now :) Is this still something you plan to do right away? Might it be something that's post 7?
this is a tricky one. The random mix adds a new track at the end if you delete a track, so the test used in default skin won't work (it matches the new track count with old track count). In Fishbone skin, when I experimented with this kind of playlist loading, I had to compare each track id, but the Default skin is optimised to avoid loading all of that info. It is also not valid to simply check the "is playlist changed" flag, as SC currently considers a change of current song as a playlist change. i did have a patch that got rid of the playlist change for a simple move to the next song, but that does require much more testing with all skins. At this point, Id suggest it may not be something we want to commit to for 7.0. Also, given that cometd is in use, it may be a post 7.0 thing to start using that for playlist updates. for now, it might be good enough to create a special case that puts up a flag for the json response saying that random mix is active, or force a reload from the playerControl function when the command is 'delete'
nevermind. above comment was for another bug.
> Random mix id's are unique now :) > Is this still something you plan to do right away? Might it be something > that's post 7? Shouldn't be that hard to do. In fact the code has +/- already been there. I think I'll do it as there will be more and more plugins and others browse modes which can profit.
Change 13423 - make sure any element of the selectorMarker class has an unique ID. This solution should be generic, so not every template making use of selectors has to care about it iself. Make sure you reload your browse and flush the cache. Re-open if needed.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.