Bugzilla – Bug 5606
Array options in Player Settings not updated after Save Settings
Last modified: 2008-12-18 11:12:53 UTC
When I enter the "Player Settings/Basic Settings" dialog the "title format" and "now playing information" options always contains an empty list box. However, when I select and value in this list box and click "Save Settings" I don't get a new empty list box. The result is that to be able to add several title formats, I need to select the first, click Save Settings, leave the dialog completely go back to "Playser Settings/Basic Settings" again and I will then get a new empty list box so I can add a second title format. In 6.5.x you got a new empty list box as soon as you pressed save, so you didn't have to leave the dialog to add several title formats.
That's a good pointer: it's basically due to the new background saving of changes. This doesn't reload the page. We'll have to think about this a bit more.
Kevin - should we go back to reloading full pages instead of background processing the settings?
best to go with what works since 7 is close. We can always try new stuff later.
...or we cover this one with bug 5992
That may be the later option.
Created attachment 2425 [details] remove submit observer removes the background submit. of course, this may mean the rescan button might be triggers on pressing enter, or other buttons along the way. we may also want to move the 'settingsRegion' div so that it includes the entire form, not just the inside. This way we ensure that the form is fully refreshed. that is, unless you feel you can move the new settings pages to EN soon enough. Even if they don't fit the skins, it would be much simpler. Hard to explain where "behavior" settings exist, now they are under SC Settings->behavior on other skins, but settings->myMusic for new Default.
I've merged in a fix at change 14885. It seems to work here, but please feel free to give it a work over and verify.
ok above typo aside, I've added some style fixes for change 14861. Original change was 14855. This is fixed for me now, so marking off. please reopen if there are any issues.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.