Bug 5602 - No albumart in genre browsing
: No albumart in genre browsing
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-28 13:06 UTC by Robin V.
Modified: 2007-09-29 12:25 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
the icon show we are in "album art" view but not the result (8.51 KB, image/png)
2007-09-28 13:08 UTC, Robin V.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robin V. 2007-09-28 13:06:39 UTC
Using fishbone skin, 
- when browsing by genre, 
- expanding the genre icon to see all artists
- select an artist, or "all albums"
-> The result is always "text result", and clicking on the right button don't change this, it's correctly cycling through "album view", "text view" with "text on" or "text off" but the result pane is not changing.
Comment 1 Robin V. 2007-09-28 13:08:21 UTC
Created attachment 2191 [details]
the icon show we are in "album art" view but not the result
Comment 2 Robin V. 2007-09-28 13:13:45 UTC
I've tested more and the problem is definitively related to "expanding the genre and clicking on all albums from the genre expanded subtree". If directly clicking on the genre without expanding, it's working
Comment 3 KDF 2007-09-28 14:36:32 UTC
I've known about this one for a while. the tree browsing was an experiment.  I had planned to remove it due to lack of support and feedback (I don't want to deal with it myself) before wide release. The descended trees really don't work with artwork but there is no way to shut it off temporarily; it ends up overriding any subsequent link to have no artwork.  
Comment 4 KDF 2007-09-28 16:21:24 UTC
ok, I think this should be much better after (a slightly ugly) change 13344. Please update and reopen if there are any issues.  I'm reluctant to have the gallery view show up while using the "tree" feature, so this makes things tricky.  If it's still not working then the feature will probably have to be disabled until some future date.
Comment 5 Robin V. 2007-09-29 02:21:02 UTC
It looks like it's working now (had to force refresh maybe because of a cached JS or strange status at the beginning).

Thanks for this
Comment 6 Robin V. 2007-09-29 02:36:03 UTC
Looks like what is correctly working in:
 genre -> expanded genre -> (all albums|given artist)

Is still broken in
search: someartist -> someartist click -> Artists albums text view -> "large artwork" icon click
results in Artists Gallery still in text view.

(i'm very tempted to open new bugs for the contest, but it's better handled as a "same bug" issue)
Comment 7 KDF 2007-09-29 12:25:01 UTC
Thanks for the reminder.  I've merged to trunk at change 13369.  I've had this particular patch for about a month now, just forgot to commit.  Probably means there is a bug report somewhere that was awaiting an answer. Marking as fxed again, but do please reopen if you have any problems.