Bug 5600 - Alternative/remove icon for "All Songs"
: Alternative/remove icon for "All Songs"
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: unspecified
: All All
: P4 minor (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-28 12:46 UTC by Neil Davidson (Funkstar)
Modified: 2009-09-08 09:24 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
No artwork for "all items" (13.49 KB, image/png)
2007-12-28 01:08 UTC, Michael Herger
Details
Alternative placeholder (18.69 KB, image/png)
2007-12-28 01:17 UTC, Michael Herger
Details
proposed "all" image with multiple albums (2.07 KB, image/png)
2007-12-28 04:33 UTC, Blackketter Dean
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Davidson (Funkstar) 2007-09-28 12:46:33 UTC
I find it distracting that the icon for "All Songs" is the same as an album missing its artwork.

Could this be changed to something else, like a musical note for example, to distinguish it from albums that really do have missing artwork?
Comment 1 Jim McAtee 2007-09-28 13:04:15 UTC
Why the need for a full-sized icon when in gallery view?  Can't 'All Songs' be given the same treatment as in prior skins - a single line with no icon?
Comment 2 Robin V. 2007-09-28 13:40:38 UTC
*** Bug 5601 has been marked as a duplicate of this bug. ***
Comment 3 KDF 2007-11-02 17:22:33 UTC
*** Bug 6012 has been marked as a duplicate of this bug. ***
Comment 4 Blackketter Dean 2007-12-27 13:30:15 UTC
Michael: is it difficult to have an empty graphic for All Songs?
Comment 5 Michael Herger 2007-12-27 14:48:23 UTC
We could probably define a special cover ID for the ALL_* browse items in browsedb.html:

Index: /Users/mh/Documents/workspace/trunk/server/Slim/Web/Graphics.pm
===================================================================
--- /Users/mh/Documents/workspace/trunk/server/Slim/Web/Graphics.pm	(revision 15627)
+++ /Users/mh/Documents/workspace/trunk/server/Slim/Web/Graphics.pm	(working copy)
@@ -171,6 +171,11 @@
 
 	$obj = Slim::Player::Playlist::song($client);
 
+} elsif ($trackid eq 'all') {
+
+	($body, $mtime, $inode, $size) = Slim::Web::HTTP::getStaticContent('path/to/some/artwork.png', $params);
+	$imageData = $$body;
+		
 } elsif ($trackid eq 'notCoverArt') {
 
 		($body, $mtime, $inode, $size) = Slim::Web::HTTP::getStaticContent($actualPathToImage, $params);
Index: /Users/mh/Documents/workspace/trunk/server/Slim/Web/Pages/BrowseDB.pm
===================================================================
--- /Users/mh/Documents/workspace/trunk/server/Slim/Web/Pages/BrowseDB.pm	(revision 15627)
+++ /Users/mh/Documents/workspace/trunk/server/Slim/Web/Pages/BrowseDB.pm	(working copy)
@@ -339,6 +339,7 @@
	$form{'attributes'}   = _attributesToKeyValuePair(\%attrs);
	$form{'levelName'}    = $levelName;
	$form{'size'}         = $prefs->get('thumbSize');
+	$form{'coverThumb'}   = 'all';
 

Didn't test this code, but I imagine it's feasible. Would need some artwork. Could start with a modified version of the current.
Comment 6 Blackketter Dean 2007-12-27 15:56:39 UTC
If it's possible to just omit the artwork, that would be optimal, otherwise spacer.gif will do nicely.


Comment 7 Michael Herger 2007-12-28 01:08:57 UTC
Created attachment 2572 [details]
No artwork for "all items"

I'm not sure this is looking good... That's my patch applied using spacer.gif. Shouldn't we use some other artwork instead?

(never mind the black corners - a remnant of the 8bit tests)
Comment 8 Michael Herger 2007-12-28 01:17:30 UTC
Created attachment 2573 [details]
Alternative placeholder

The return of the question mark?...
Comment 9 Jim McAtee 2007-12-28 01:53:54 UTC
No, not the question mark! :)  What would make sense for "All Songs"?  Maybe an icon showing multiple small music notes?
Comment 10 Blackketter Dean 2007-12-28 04:33:46 UTC
Created attachment 2574 [details]
proposed "all" image with multiple albums

How about an image with multiple albums?
Comment 11 Blackketter Dean 2007-12-28 04:34:24 UTC
Noah should be the one making the final image.
Comment 12 Neil Davidson (Funkstar) 2007-12-28 04:42:18 UTC
(In reply to comment #10)
> Created an attachment (id=2574) [edit]
> proposed "all" image with multiple albums
> How about an image with multiple albums?
That looks better :)
Comment 13 Michael Herger 2007-12-28 05:03:11 UTC
Change 15663 - add special cover artwork for the "All Songs" item: 
/music/all_items/cover.png

Ben - could you please use the above url for that menu item on Jive?
Comment 14 Ben Klaas 2007-12-28 07:28:12 UTC
SC change 15672 pushes new "all" image to Jive for "Play All" menu item.

This isn't a Noah-created icon is it? If not, the bug should be left open and he should have final say on what the artwork will be.
Comment 15 Blackketter Dean 2007-12-28 08:29:59 UTC
Noah will be dropping a new set of tweaked icons.  We'll close this one and reopen if his new set has issues.
Comment 16 Ben Klaas 2007-12-28 11:35:54 UTC
FYI, it's actually change 15695 on SC that addresses this issue for Jive
Comment 17 Chris Owens 2008-03-07 09:04:17 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.