Bugzilla – Bug 5600
Alternative/remove icon for "All Songs"
Last modified: 2009-09-08 09:24:08 UTC
I find it distracting that the icon for "All Songs" is the same as an album missing its artwork. Could this be changed to something else, like a musical note for example, to distinguish it from albums that really do have missing artwork?
Why the need for a full-sized icon when in gallery view? Can't 'All Songs' be given the same treatment as in prior skins - a single line with no icon?
*** Bug 5601 has been marked as a duplicate of this bug. ***
*** Bug 6012 has been marked as a duplicate of this bug. ***
Michael: is it difficult to have an empty graphic for All Songs?
We could probably define a special cover ID for the ALL_* browse items in browsedb.html: Index: /Users/mh/Documents/workspace/trunk/server/Slim/Web/Graphics.pm =================================================================== --- /Users/mh/Documents/workspace/trunk/server/Slim/Web/Graphics.pm (revision 15627) +++ /Users/mh/Documents/workspace/trunk/server/Slim/Web/Graphics.pm (working copy) @@ -171,6 +171,11 @@ $obj = Slim::Player::Playlist::song($client); +} elsif ($trackid eq 'all') { + + ($body, $mtime, $inode, $size) = Slim::Web::HTTP::getStaticContent('path/to/some/artwork.png', $params); + $imageData = $$body; + } elsif ($trackid eq 'notCoverArt') { ($body, $mtime, $inode, $size) = Slim::Web::HTTP::getStaticContent($actualPathToImage, $params); Index: /Users/mh/Documents/workspace/trunk/server/Slim/Web/Pages/BrowseDB.pm =================================================================== --- /Users/mh/Documents/workspace/trunk/server/Slim/Web/Pages/BrowseDB.pm (revision 15627) +++ /Users/mh/Documents/workspace/trunk/server/Slim/Web/Pages/BrowseDB.pm (working copy) @@ -339,6 +339,7 @@ $form{'attributes'} = _attributesToKeyValuePair(\%attrs); $form{'levelName'} = $levelName; $form{'size'} = $prefs->get('thumbSize'); + $form{'coverThumb'} = 'all'; Didn't test this code, but I imagine it's feasible. Would need some artwork. Could start with a modified version of the current.
If it's possible to just omit the artwork, that would be optimal, otherwise spacer.gif will do nicely.
Created attachment 2572 [details] No artwork for "all items" I'm not sure this is looking good... That's my patch applied using spacer.gif. Shouldn't we use some other artwork instead? (never mind the black corners - a remnant of the 8bit tests)
Created attachment 2573 [details] Alternative placeholder The return of the question mark?...
No, not the question mark! :) What would make sense for "All Songs"? Maybe an icon showing multiple small music notes?
Created attachment 2574 [details] proposed "all" image with multiple albums How about an image with multiple albums?
Noah should be the one making the final image.
(In reply to comment #10) > Created an attachment (id=2574) [edit] > proposed "all" image with multiple albums > How about an image with multiple albums? That looks better :)
Change 15663 - add special cover artwork for the "All Songs" item: /music/all_items/cover.png Ben - could you please use the above url for that menu item on Jive?
SC change 15672 pushes new "all" image to Jive for "Play All" menu item. This isn't a Noah-created icon is it? If not, the bug should be left open and he should have final say on what the artwork will be.
Noah will be dropping a new set of tweaked icons. We'll close this one and reopen if his new set has issues.
FYI, it's actually change 15695 on SC that addresses this issue for Jive
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.