Bug 5595 - Play Other Songs In Album - player setting?
: Play Other Songs In Album - player setting?
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: PC Windows XP
: P3 enhancement (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-28 09:39 UTC by Mick
Modified: 2011-01-24 00:16 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mick 2007-09-28 09:39:42 UTC
SqueezeCenter Version: 7.0 - 13321 - Windows XP - EN - cp1252
Server IP address: 192.168.2.3
Perl Version: 5.8.8 MSWin32-x86-multi-thread
MySQL Version: 5.0.22-community-nt

No matter what the setting is set to, Squeezecenter only adds the selected song to the playlist and not the entire album as expected.

This only happens when you select a song from the left hand panel of the webui and click the small play button beside the track.


The player ui works as expected.


Jive exhibits the same behaviour as the webui.
Comment 1 KDF 2007-09-28 09:45:40 UTC
The "play other songs on album" is for the playerUI only only.
Comment 2 Blackketter Dean 2007-09-28 10:16:26 UTC
This should be a player setting and only for SLIMP3 or SB1/2/3.  The instructional text should replaced with:

When you select a single song from an album or folder and press PLAY on the remote, you can play just that song or all the songs with it, starting with that song.
Comment 3 Blackketter Dean 2007-09-28 10:17:11 UTC
Add transporter to that list.  Basically any device with a one or two line display. 
Comment 4 KDF 2007-09-28 10:18:44 UTC
change 9606 removed the "on the remote" part of the description.  Languages other than EN still mention the remote, so the EN text needs to be reverted (and other languages should be reviewed to be sure they all mention the remote):

Index: C:/slim/server/strings.txt
===================================================================
--- C:/slim/server/strings.txt	(revision 13329)
+++ C:/slim/server/strings.txt	(working copy)
@@ -5475,6 +5475,6 @@
 	CS	Pokud vyberete jednu skladbu a stisknete PLAY na dálkovém ovladači, můžete zvolit zda se má hrát pouze tato skladba, nebo celé album obsahující tuto skladbu, nebo celý adresář, začíníjící touto skladbou.
 	DA	Når du vælger en enkelt sang og trykker PLAY, kan du vælge om kun den valgte sang skal afspilles eller om alle sange fra det album eller i den mappe skal afspilles (startende med den valgte sang).
 	DE	Wenn Sie einen Titel auswählen und PLAY drücken, können Sie hier festlegen, ob nur dieses eine oder alle Titel aus diesem Album oder Ordner wiedergegeben werden soll.
-	EN	When you select a single song and press PLAY, while browsing albums or folders, you can choose to play just that song or all the songs in that album or directory, starting with that song.
+	EN	When you select a single song and press PLAY on the remote, while browsing albums or folders, you can choose to play just that song or all the songs in that album or directory, starting with that song.
 	ES	Cuando se selecciona una sola canción y se pulsa PLAY en el mando a distancia, se puede optar por reproducir sólo esa canción o todas las canciones de ese álbum o directorio, empezando por esa canción.
 	FR	Lorsque vous choisissez un morceau et que vous appuyez sur le bouton PLAY de la télécommande, la platine peut lire uniquement ce morceau ou tous les morceaux de l'album ou du dossier en commençant par le morceau choisi.

Comment 5 KDF 2007-09-28 10:30:00 UTC
It might make sense to move this setting into player settings to make it even more clear.
Any suggestions for which page?
Basic, Alarm, Audio, Display, Menu, Remote(ir)
Comment 6 Blackketter Dean 2007-09-28 19:08:32 UTC
Put it in Basic for now.  Brian Dils is doing some cleanup of the organization in there and may want to move or tweak the text.
Comment 7 KDF 2007-09-28 19:42:51 UTC
hrm...contextually its a player setting (given that some players are not applicable, such as http clients). However, we're handling it as a global server setting.  Should we change it so that it is per player throughout the server??  

I think I'll change the strings only for now.  Lets think about this some more when Brian has had some time to give everything a look.
Comment 8 Blackketter Dean 2007-09-28 22:10:07 UTC
Yes. It should be per-player, as it affects the player's interface.
Comment 9 KDF 2007-09-28 22:36:31 UTC
ok, then each player will act according to the setting for that player.  We'll leave the old server pref dead, create a new default for all players (feel free to let me know if you have a specific pref on or off soon).  I'll have that done shortly.
Comment 10 KDF 2007-09-28 23:03:05 UTC
fixed at change 13353.  I'll eave open in case we want to rename as placeholder for the settings refactor or feel freee to mark as fixed if no placeholder is required.
Comment 11 Blackketter Dean 2007-09-29 09:08:20 UTC
The default setting should probably come from the server setting (if it exists) as a way to migrate somebody who already changed it.
Comment 12 KDF 2007-09-29 11:32:50 UTC
change 13366 restores the old server default (so that we always have the fallback).  Feature now checks player pref, then if it is not defined, it will look to the old server pref to act on that.
Comment 13 Mick 2007-09-29 12:33:24 UTC
Maybe I'm a bit thick (don't answer) but does this mean that Jive will act as a web client and therefore not support selecting say song 5 of an album and then playing from there. i.e. playing all songs on an album after selecting 1.

If so ,that is quite a loss of functionality. I use this a lot and suspect that I'm not alone.
Comment 14 KDF 2007-09-29 12:48:36 UTC
It's not a loss of functionality, as the remote is the remote and Jive is something else entirely.  The function for jive does operate as a web client currently.  any change to that could be made as an enhancement request.  Perhaps through cometd we could use the feature (though I am not sure how to differentiate web/cometd as they both go through the CLI). 
 As for having the play others feature for web, etc outside of remote control only, that's a discussion i've done before I'll leave it to Dean on this one.
 
Comment 15 Chris Owens 2007-10-01 12:40:12 UTC
Shall I assign this to Brian Dils then, Dean?
Comment 16 Brian Dils 2007-10-01 13:16:53 UTC
I am in fact working in this issue so yeah you can assign it to me...
Comment 17 Chris Owens 2007-10-01 13:43:00 UTC
Excellent!  And I didn't even have to trick you into getting a bugzilla account!  :)

When you think it's been fixed, remember to 'Resolve' the bug as 'Fixed.'  If it's important, QA may mark it as 'Verified' and then it will be marked 'closed' either by the original submitter or by me at the time of the 7.0 release.  

For any reason at any time you can of course assign it back to qa@slimdevices.com for any further actions that need to be taken!
Comment 18 KDF 2007-11-11 00:07:59 UTC
see also bug 5981 as it affects this pref with respect to Jive.
Comment 19 Chris Owens 2008-06-23 09:39:39 UTC
Brian what is the status of this?
Comment 20 Brian Dils 2008-06-24 12:04:51 UTC
I've had to push this back, should be able to get to this next week
Comment 21 Blackketter Dean 2008-08-04 12:48:21 UTC
Brian:  We need this asap.
Comment 22 Blackketter Dean 2008-08-06 12:09:22 UTC
Ping Brian!  
Comment 23 Mickey Gee 2008-08-07 14:30:46 UTC
Moving to 7.3 to continue investigation by Brian.
Comment 24 Mickey Gee 2008-10-24 15:02:40 UTC
This should behave consistently in all UIs, says Brian. When you play a track it should play the rest of the album. We shouldn't clutter settings with another setting for this.

Comment 25 Michael Herger 2008-10-27 06:40:39 UTC
If we do change this behaviour in the web UI we'll remove the last way of reasonably creating playlists. People will hate us a _lot_.

Consistency is a nice thing, but sometimes we have to take advantage of bigger screens, better UI and interaction. IMHO it makes sense to have an option to add all remaining items on an IR remote, as playing one after the other hurts much more than in the web UI.
Comment 26 Michael Herger 2008-11-05 05:11:44 UTC
No decision has been taken we'll implement this.
Comment 27 KDF 2008-11-07 08:59:34 UTC
Michael, here's a thought regarding the making of playlists:

Press Play - clears any existing playlist and plays the album/folder starting with the selected track.

Press ADD - add just the selected item.  This could also simply add an item to an empty playlist.  

The cost here is that to start a new playlist with just ONE track, the user now has to clear the playlist first. 

Still need that "do exactly what I'm thinking" button. The patent would be worth billions.

Comment 28 Chris Owens 2008-11-10 09:29:44 UTC
This needs to be thought out in additional detail before we implement it.  The SBC interface is now the same as the player, and the web is fundamentally different.
Comment 29 James Richardson 2008-12-29 16:07:21 UTC
*** Bug 10484 has been marked as a duplicate of this bug. ***
Comment 30 Alan Young 2011-01-24 00:16:42 UTC
Works as designed (now).